You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Matthias Andree <ma...@gmx.de> on 2009/06/03 07:36:48 UTC
mod_dav_svn issue? (was: git-svn: refuse to dcommit non-UTF-8
messages)
ping - should I just file an issue in the tracker if nobody cares to look
here?
Delegating input delegation to clients such as Perl/SVN::Ra, rather than
having the server - mod_dav_svn or whatever - check the commit log
character set seems like a serious issue (design flaw) to me (and checking
if something remotely looks like UTF-8 isn't exactly difficult, look at
Markus Kuhn's pages for code if you need to pinch it...)
Git-SVN's fixing this is just a workaround for SVN design flaws and
implementation bugs.
--
Matthias Andree
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2359011
To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].
Re: mod_dav_svn issue? (was: git-svn: refuse to dcommit non-UTF-8
messages)
Posted by Matthias Andree <ma...@gmx.de>.
Am 03.06.2009, 18:45 Uhr, schrieb Matthias Andree <ma...@gmx.de>:
> Am 03.06.2009, 16:18 Uhr, schrieb Stefan Sperling <st...@elego.de>:
>
>> On Wed, Jun 03, 2009 at 09:36:48AM +0200, Matthias Andree wrote:
>>> ping - should I just file an issue in the tracker if nobody cares to
>>> look here?
>>>
>>> Delegating input delegation to clients such as Perl/SVN::Ra, rather
>>> than
>>> having the server - mod_dav_svn or whatever - check the commit log
>>> character set seems like a serious issue (design flaw) to me (and
>>> checking if something remotely looks like UTF-8 isn't exactly
>>> difficult, look at
>>> Markus Kuhn's pages for code if you need to pinch it...)
>>
>> Which version of Subversion are you using?
>> This problem has already been fixed a while back.
>> 1.6.x should not have this problem.
>
> Hi Stefan,
>
> thanks for the pointer and log message you'd included.
>
> I'll check with our NOC for the version they'd been running on the server
> and have their butts kicked if they'd been running an antediluvian
> version (they've run into other - fixed - issues, such as ill-formed XML
> output on non-UTF-8-log messages, so likely it was an older version, but
> I'll check).
following up to myself,
it was indeed 1.5 they'd been running and they (NOC) are now checking 1.6
update options.
I'll consider this closed in as far as subversion is concerned. Thanks
again.
Best regards
--
Matthias Andree
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2359669
To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].
Re: mod_dav_svn issue? (was: git-svn: refuse to dcommit non-UTF-8
messages)
Posted by Matthias Andree <ma...@gmx.de>.
Am 03.06.2009, 16:18 Uhr, schrieb Stefan Sperling <st...@elego.de>:
> On Wed, Jun 03, 2009 at 09:36:48AM +0200, Matthias Andree wrote:
>> ping - should I just file an issue in the tracker if nobody cares to
>> look here?
>>
>> Delegating input delegation to clients such as Perl/SVN::Ra, rather than
>> having the server - mod_dav_svn or whatever - check the commit log
>> character set seems like a serious issue (design flaw) to me (and
>> checking if something remotely looks like UTF-8 isn't exactly
>> difficult, look at
>> Markus Kuhn's pages for code if you need to pinch it...)
>
> Which version of Subversion are you using?
> This problem has already been fixed a while back.
> 1.6.x should not have this problem.
Hi Stefan,
thanks for the pointer and log message you'd included.
I'll check with our NOC for the version they'd been running on the server
and have their butts kicked if they'd been running an antediluvian version
(they've run into other - fixed - issues, such as ill-formed XML output on
non-UTF-8-log messages, so likely it was an older version, but I'll check).
> ------------------------------------------------------------------------
> r31614 | kfogel | 2008-06-06 19:28:03 +0100 (Fri, 06 Jun 2008) | 26 lines
>
> Fix issue #1796: prevent invalid log messages from entering the
> repository.
>> Git-SVN's fixing this is just a workaround for SVN design flaws and
>> implementation bugs.
>
> And let me guess -- git doesn't have any of those? ;)
Sure it does, but in this particular case, fixing git-svn was just a
courtesy, and fixing svn was the real fix.
--
Matthias Andree
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2359133
To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].
Re: mod_dav_svn issue? (was: git-svn: refuse to dcommit non-UTF-8
messages)
Posted by Stefan Sperling <st...@elego.de>.
On Wed, Jun 03, 2009 at 09:36:48AM +0200, Matthias Andree wrote:
> ping - should I just file an issue in the tracker if nobody cares to look
> here?
>
> Delegating input delegation to clients such as Perl/SVN::Ra, rather than
> having the server - mod_dav_svn or whatever - check the commit log
> character set seems like a serious issue (design flaw) to me (and checking
> if something remotely looks like UTF-8 isn't exactly difficult, look at
> Markus Kuhn's pages for code if you need to pinch it...)
Which version of Subversion are you using?
This problem has already been fixed a while back.
1.6.x should not have this problem.
------------------------------------------------------------------------
r31614 | kfogel | 2008-06-06 19:28:03 +0100 (Fri, 06 Jun 2008) | 26 lines
Fix issue #1796: prevent invalid log messages from entering the repository.
Although our client does not send invalid messages, a defective or
malicious client could, thus corrupting the repository metadata.
Patch by: Neels Janosch Hofmeyr <ne...@elego.de>
(Tweaked by me; previous iterations reviewed by danielsh.)
* subversion/include/private/svn_utf_private.h: New file.
(svn_utf__is_valid): Moved here from libsvn_subr/utf_impl.h,
because needed in libsvn_repos.
* subversion/libsvn_subr/utf_impl.h: Include private/svn_utf_private.h.
(svn_utf__is_valid): Moved to svn_utf_private.h.
(svn_utf__last_valid): Add comment mentioning svn_utf__is_valid.
* subversion/libsvn_repos/fs-wrap.c
(validate_prop): Validate log messages.
* subversion/include/svn_repos.h
(svn_repos_fs_change_node_prop): Document validation behavior.
* subversion/tests/libsvn_repos/repos-test.c
(prop_validation_commit_with_revprop): New helper function.
(prop_validation): New test.
(test_funcs): Run it.
------------------------------------------------------------------------
r34106 | danielsh | 2008-11-07 22:28:47 +0000 (Fri, 07 Nov 2008) | 7 lines
Fix issue #3313 by validating all eligible properties (and among them,
svn:author) for being valid UTF-8.
* subversion/libsvn_repos/fs-wrap.c
(validate_prop):
Apply the "is UTF-8 and LF" check whenever svn_prop_needs_translation()
is true (that is the very definition of the latter).
> Git-SVN's fixing this is just a workaround for SVN design flaws and
> implementation bugs.
And let me guess -- git doesn't have any of those? ;)
Stefan