You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/07 10:30:15 UTC

[GitHub] [commons-compress] PeterAlfreadLee opened a new pull request #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

PeterAlfreadLee opened a new pull request #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry
URL: https://github.com/apache/commons-compress/pull/96
 
 
   Add testcases for zip, including ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] bodewig commented on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

Posted by GitBox <gi...@apache.org>.
bodewig commented on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry
URL: https://github.com/apache/commons-compress/pull/96#issuecomment-596111716
 
 
   Thanks @PeterAlfreadLee - I've just added a few comments about unnecessary new imports.
   
   BTW, I think it is time you add yourself as developer to the POM. :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] PeterAlfreadLee commented on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

Posted by GitBox <gi...@apache.org>.
PeterAlfreadLee commented on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry
URL: https://github.com/apache/commons-compress/pull/96#issuecomment-596289352
 
 
   Oops, I forgot to delete the imports when I was debugging. Sorry about that.
   And I added myself as a developer in pom. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] coveralls edited a comment on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry
URL: https://github.com/apache/commons-compress/pull/96#issuecomment-596072872
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29211517/badge)](https://coveralls.io/builds/29211517)
   
   Coverage increased (+0.2%) to 87.184% when pulling **b5fc5bd8d752bff0f586476f8dd1073b1d577d81 on PeterAlfreadLee:ADD_TESTCASES_FOR_ZIP** into **d4baab1bf83cbb16fff5620fc45fb95859852657 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] bodewig commented on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

Posted by GitBox <gi...@apache.org>.
bodewig commented on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry
URL: https://github.com/apache/commons-compress/pull/96#issuecomment-596338380
 
 
   Thank you

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] bodewig commented on a change in pull request #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

Posted by GitBox <gi...@apache.org>.
bodewig commented on a change in pull request #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry
URL: https://github.com/apache/commons-compress/pull/96#discussion_r389293600
 
 

 ##########
 File path: src/test/java/org/apache/commons/compress/archivers/zip/ZipArchiveEntryTest.java
 ##########
 @@ -22,6 +22,9 @@
 import static org.junit.Assert.*;
 
 import java.io.ByteArrayOutputStream;
+import java.lang.reflect.Field;
+import java.lang.reflect.Modifier;
+import java.util.Arrays;
 
 Review comment:
   These are not sctually needed, are they?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] coveralls commented on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry
URL: https://github.com/apache/commons-compress/pull/96#issuecomment-596072872
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29196607/badge)](https://coveralls.io/builds/29196607)
   
   Coverage increased (+0.2%) to 87.182% when pulling **f2c09166ddd3f7af8afbcd70eb4a02ce99cda0eb on PeterAlfreadLee:ADD_TESTCASES_FOR_ZIP** into **1e8d131ec08ae418f0140d8166d452dff6739937 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] bodewig merged pull request #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

Posted by GitBox <gi...@apache.org>.
bodewig merged pull request #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry
URL: https://github.com/apache/commons-compress/pull/96
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-compress] bodewig commented on a change in pull request #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry

Posted by GitBox <gi...@apache.org>.
bodewig commented on a change in pull request #96: Add testcases for ZipUtil, ZipFile, ZipArchiveOutputStream and ZipArchiveEntry
URL: https://github.com/apache/commons-compress/pull/96#discussion_r389294213
 
 

 ##########
 File path: src/test/java/org/apache/commons/compress/archivers/zip/ZipUtilTest.java
 ##########
 @@ -20,6 +20,7 @@
 
 import static org.junit.Assert.*;
 
+import java.io.UnsupportedEncodingException;
 
 Review comment:
   not used?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services