Re: [PR] [FLINK-33549][table-runtime] Enable BatchMultipleInputStreamOperatorFactory to support YieldingOperatorFactory interface [flink]

["xuyangzhong (via GitHub)" <gi...@apache.org>]

xuyangzhong commented on code in PR #24259:
URL: https://github.com/apache/flink/pull/24259#discussion_r1480812721


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/BatchMultipleInputStreamOperatorFactory.java:
##########
@@ -21,14 +21,15 @@
 import org.apache.flink.streaming.api.operators.AbstractStreamOperatorFactory;
 import org.apache.flink.streaming.api.operators.StreamOperator;
 import org.apache.flink.streaming.api.operators.StreamOperatorParameters;
+import org.apache.flink.streaming.api.operators.YieldingOperatorFactory;
 import org.apache.flink.table.data.RowData;
 import org.apache.flink.table.runtime.operators.multipleinput.input.InputSpec;
 
 import java.util.List;
 
 /** The factory to create {@link BatchMultipleInputStreamOperator}. */
-public class BatchMultipleInputStreamOperatorFactory
-        extends AbstractStreamOperatorFactory<RowData> {
+public class BatchMultipleInputStreamOperatorFactory extends AbstractStreamOperatorFactory<RowData>
+        implements YieldingOperatorFactory<RowData> {

Review Comment:
   Just a little curious, why no tests are added for this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org