You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (Resolved) (JIRA)" <ji...@apache.org> on 2012/02/20 22:41:35 UTC

[jira] [Resolved] (QPID-3728) some uses of QBTC.isExternalBroker() are incorrect during 'same-VM' testing following broker startup refactoring

     [ https://issues.apache.org/jira/browse/QPID-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell resolved QPID-3728.
----------------------------------

    Resolution: Fixed

Removed 1 restriction from DurableSubscriptionTest. All the other restrictions are in BrokerLoggingTest, which we need to rework anyway and actually I'm quite ok with those sorts of tests only running on the external profiles so they can jsut stay the way they are.
                
> some uses of QBTC.isExternalBroker() are incorrect during 'same-VM' testing following broker startup refactoring
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3728
>                 URL: https://issues.apache.org/jira/browse/QPID-3728
>             Project: Qpid
>          Issue Type: Test
>          Components: Java Broker, Java Tests
>    Affects Versions: 0.14
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.15
>
>
> Prior to the removal of Mina, same-VM testing of the client and broker used to rely on the Mina InVM transport and the 0-8 protocol. Support for the InVM transport was removed when refactoring the broker to allow testing all protocol versions 'sameVM' while using TCP, after which use of Mina was eventually removed entirely. The previous differences between how the broker was started for InVM and 'standalone' external testing meant some of its behaviour was different and some tests required branches in behaviour to compensate.
> Some tests which use the isExternalBroker() utility method will no longer need to, as almost all of the broker startup is now common between the 'sameVM' and 'external' brokers used in testing and their behaviour is largely indistinguishable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org