You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/03/19 20:48:32 UTC
[GitHub] [pulsar] lovelle opened a new pull request #3863: [cpp client]
implement reference count for close()
lovelle opened a new pull request #3863: [cpp client] implement reference count for close()
URL: https://github.com/apache/pulsar/pull/3863
Add reference count feature to keep track of reused instances of a consumer
instance, for more details please see commit ff4db8d.
*Modifications*
- Add refCount instance variable on ConsumerImpl.
- Use new shouldTearDown() on close() in order to know whether effective close
call should occur or not.
- Increment reference count when a previous built consumer instance is being
used by caller.
*Future considerations*
Thereafter when feature preventing duplicated consumer is made for
PartitionedConsumer, MultiTopicsConsumer and PatternMultiTopicsConsumer,
incrRefCount() member could be turned into a pure virtual method.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services