You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/06/06 19:29:07 UTC
[GitHub] [pinot] shenyu0127 opened a new pull request, #10860: Select distinct multi-column NULL support.
shenyu0127 opened a new pull request, #10860:
URL: https://github.com/apache/pinot/pull/10860
This PR enables NULL support for queries like `SELECT DISTINCT col1, col2 from testTable ORDER BY col1, col2`.
Tested in unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on pull request #10860: Select distinct multi-column NULL support.
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #10860:
URL: https://github.com/apache/pinot/pull/10860#issuecomment-1585179918
> > Do we need to handle the other branch (when `_hasMVExpression` is true)
>
> Currently multi-value null support is out of scope: all the previous null support work did not touch the multi-value code.
Added a TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10860: Select distinct multi-column NULL support.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10860:
URL: https://github.com/apache/pinot/pull/10860#issuecomment-1579416295
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10860](https://app.codecov.io/gh/apache/pinot/pull/10860?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2df3d00) into [master](https://app.codecov.io/gh/apache/pinot/commit/f8766129f06f29894b7e7c2dc1fed3b36af75d16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f876612) will **decrease** coverage by `29.92%`.
> The diff coverage is `54.83%`.
```diff
@@ Coverage Diff @@
## master #10860 +/- ##
=============================================
- Coverage 64.40% 34.49% -29.92%
+ Complexity 6558 462 -6096
=============================================
Files 2120 2174 +54
Lines 114345 116855 +2510
Branches 17390 17696 +306
=============================================
- Hits 73644 40306 -33338
- Misses 35402 73037 +37635
+ Partials 5299 3512 -1787
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `23.93% <38.70%> (?)` | |
| integration2 | `23.68% <54.83%> (?)` | |
| unittests1 | `?` | |
| unittests2 | `13.70% <0.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...t/server/api/resources/SegmentMetadataFetcher.java](https://app.codecov.io/gh/apache/pinot/pull/10860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvYXBpL3Jlc291cmNlcy9TZWdtZW50TWV0YWRhdGFGZXRjaGVyLmphdmE=) | `53.52% <33.33%> (ø)` | |
| [...y/distinct/raw/RawMultiColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3TXVsdGlDb2x1bW5EaXN0aW5jdEV4ZWN1dG9yLmphdmE=) | `27.61% <53.33%> (-59.12%)` | :arrow_down: |
| [...t/core/query/distinct/DistinctExecutorFactory.java](https://app.codecov.io/gh/apache/pinot/pull/10860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9EaXN0aW5jdEV4ZWN1dG9yRmFjdG9yeS5qYXZh) | `66.25% <66.66%> (-23.75%)` | :arrow_down: |
| [...pache/pinot/core/query/distinct/DistinctTable.java](https://app.codecov.io/gh/apache/pinot/pull/10860?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9EaXN0aW5jdFRhYmxlLmphdmE=) | `50.52% <100.00%> (-27.91%)` | :arrow_down: |
... and [1558 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10860/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on pull request #10860: Select distinct multi-column NULL support.
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #10860:
URL: https://github.com/apache/pinot/pull/10860#issuecomment-1584069497
> Do we need to handle the other branch (when `_hasMVExpression` is true)
Currently multi-value null support is out of scope: all the previous null support work did not touch the multi-value code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10860: Select distinct multi-column NULL support.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10860:
URL: https://github.com/apache/pinot/pull/10860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org