You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/12/19 23:08:31 UTC
[GitHub] [trafficcontrol] tcfdev opened a new pull request, #7258: Add install nodejs line to Dockerfile
tcfdev opened a new pull request, #7258:
URL: https://github.com/apache/trafficcontrol/pull/7258
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
Closes: #7257
After using the `curl -sL https://rpm.nodesource.com/setup_18.x | bash -` it is still necessary to run `npm install -y nodejs`
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Portal
- CDN in a Box
- Automation (CIAB Traffic Portal Integration Tests) <!-- Please specify which (GitHub Actions, Docker images, Ansible Roles, etc.) -->
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Run traffic_portal_integration_test in CIAB to ensure NodeJS v18.x is installed correctly and the tests pass.
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
Master only
## PR submission checklist
- [ ] This PR has tests - This should fix a test<!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation - No documentation required<!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry - Adds to a previously merged PR to fix a test. No change to functionality. <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] tcfdev commented on a diff in pull request #7258: Add install nodejs line to Dockerfile
Posted by GitBox <gi...@apache.org>.
tcfdev commented on code in PR #7258:
URL: https://github.com/apache/trafficcontrol/pull/7258#discussion_r1053538826
##########
infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile:
##########
@@ -48,6 +48,7 @@ RUN if [[ "${RHEL_VERSION%%.*}" -eq 7 ]]; then \
FROM os-dependencies AS node-dependencies
# Download and install node
RUN curl -sL https://rpm.nodesource.com/setup_18.x | bash -
+RUN dnf install -y nodejs
Review Comment:
There is a line towards the beginning to ensure `dnf` is installed as the rest of the Dockerfile depends on it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] tcfdev commented on a diff in pull request #7258: Add install nodejs line to Dockerfile
Posted by GitBox <gi...@apache.org>.
tcfdev commented on code in PR #7258:
URL: https://github.com/apache/trafficcontrol/pull/7258#discussion_r1053538826
##########
infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile:
##########
@@ -48,6 +48,7 @@ RUN if [[ "${RHEL_VERSION%%.*}" -eq 7 ]]; then \
FROM os-dependencies AS node-dependencies
# Download and install node
RUN curl -sL https://rpm.nodesource.com/setup_18.x | bash -
+RUN dnf install -y nodejs
Review Comment:
There is a line at the beginning to ensure `dnf` is installed as the rest of the Dockerfile depends on it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a merged pull request #7258: Add install nodejs line to Dockerfile
Posted by GitBox <gi...@apache.org>.
jhg03a merged PR #7258:
URL: https://github.com/apache/trafficcontrol/pull/7258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on a diff in pull request #7258: Add install nodejs line to Dockerfile
Posted by GitBox <gi...@apache.org>.
jhg03a commented on code in PR #7258:
URL: https://github.com/apache/trafficcontrol/pull/7258#discussion_r1053540499
##########
infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile:
##########
@@ -48,6 +48,7 @@ RUN if [[ "${RHEL_VERSION%%.*}" -eq 7 ]]; then \
FROM os-dependencies AS node-dependencies
# Download and install node
RUN curl -sL https://rpm.nodesource.com/setup_18.x | bash -
+RUN dnf install -y nodejs
Review Comment:
I take it back, we did the bits to add dnf backward into Centos7 and dnf is consistent with the rest of the dockerfile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jhg03a commented on a diff in pull request #7258: Add install nodejs line to Dockerfile
Posted by GitBox <gi...@apache.org>.
jhg03a commented on code in PR #7258:
URL: https://github.com/apache/trafficcontrol/pull/7258#discussion_r1053533506
##########
infrastructure/cdn-in-a-box/traffic_portal_integration_test/Dockerfile:
##########
@@ -48,6 +48,7 @@ RUN if [[ "${RHEL_VERSION%%.*}" -eq 7 ]]; then \
FROM os-dependencies AS node-dependencies
# Download and install node
RUN curl -sL https://rpm.nodesource.com/setup_18.x | bash -
+RUN dnf install -y nodejs
Review Comment:
This should use yum rather than dnf for Centos7 backward compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org