You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/12 12:28:14 UTC

[GitHub] [spark] WeichenXu123 commented on a change in pull request #27522: [SPARK-30762] Add dtype=float32 support to vector_to_array UDF

WeichenXu123 commented on a change in pull request #27522: [SPARK-30762] Add dtype=float32 support to vector_to_array UDF
URL: https://github.com/apache/spark/pull/27522#discussion_r378220187
 
 

 ##########
 File path: python/pyspark/ml/functions.py
 ##########
 @@ -20,7 +20,7 @@
 
 
 @since(3.0)
-def vector_to_array(col):
+def vector_to_array(col, dtype="float64"):
     """
     Converts a column of MLlib sparse/dense vectors into a column of dense arrays.
 
 Review comment:
   Add doc for params and return type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org