You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Gary VanMatre (JIRA)" <ad...@incubator.apache.org> on 2007/02/04 01:31:05 UTC

[jira] Created: (ADFFACES-372) The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.

The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.
---------------------------------------------------------------------------------------------------

                 Key: ADFFACES-372
                 URL: https://issues.apache.org/jira/browse/ADFFACES-372
             Project: MyFaces ADF-Faces
          Issue Type: Bug
          Components: Plugins
            Reporter: Gary VanMatre


The plugin scans dependent jars for tag library descriptors and copies them to the WEB-INF folder of the target web project.   The source and target file names are identical.  This causes a problem if all the TLD files are not uniquely named.

Shale has this scenario.  Three of the shale libraries have TLD's sharing the same name "taglib.tld".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ADFFACES-372) The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.

Posted by "Gary VanMatre (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary VanMatre updated ADFFACES-372:
-----------------------------------

    Attachment: maven-jdev-plugin.patch

The proposed patch appends the file size to the target filename. Of course this will not guarantee a unique file name but it's unlikely that the file sizes will be the same for two different libraries.


> The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-372
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-372
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Gary VanMatre
>         Attachments: maven-jdev-plugin.patch
>
>
> The plugin scans dependent jars for tag library descriptors and copies them to the WEB-INF folder of the target web project.   The source and target file names are identical.  This causes a problem if all the TLD files are not uniquely named.
> Shale has this scenario.  Three of the shale libraries have TLD's sharing the same name "taglib.tld".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ADFFACES-372) The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Winer resolved ADFFACES-372.
---------------------------------

    Resolution: Fixed
      Assignee: Adam Winer

Checked in patch.  Thanks, Gary!

> The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-372
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-372
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Gary VanMatre
>         Assigned To: Adam Winer
>         Attachments: maven-jdev-plugin.patch, maven-jdev-plugin.patch
>
>
> The plugin scans dependent jars for tag library descriptors and copies them to the WEB-INF folder of the target web project.   The source and target file names are identical.  This causes a problem if all the TLD files are not uniquely named.
> Shale has this scenario.  Three of the shale libraries have TLD's sharing the same name "taglib.tld".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ADFFACES-372) The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/ADFFACES-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471119 ] 

Adam Winer commented on ADFFACES-372:
-------------------------------------

Couldn't we append something else on detection of a duplicate - like just a counter?  Or , even better, the name of the JAR? I'd also really only like to change the name when we detect a duplicate.

> The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-372
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-372
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Gary VanMatre
>         Attachments: maven-jdev-plugin.patch
>
>
> The plugin scans dependent jars for tag library descriptors and copies them to the WEB-INF folder of the target web project.   The source and target file names are identical.  This causes a problem if all the TLD files are not uniquely named.
> Shale has this scenario.  Three of the shale libraries have TLD's sharing the same name "taglib.tld".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ADFFACES-372) The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Winer updated ADFFACES-372:
--------------------------------

    Status: Open  (was: Patch Available)

> The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-372
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-372
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Gary VanMatre
>         Attachments: maven-jdev-plugin.patch
>
>
> The plugin scans dependent jars for tag library descriptors and copies them to the WEB-INF folder of the target web project.   The source and target file names are identical.  This causes a problem if all the TLD files are not uniquely named.
> Shale has this scenario.  Three of the shale libraries have TLD's sharing the same name "taglib.tld".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ADFFACES-372) The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.

Posted by "Gary VanMatre (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary VanMatre updated ADFFACES-372:
-----------------------------------

    Attachment: maven-jdev-plugin.patch

This patch is a variation of the first.  It appends the jar name to TLD's that have the same names.  The jar name is only appended if there is a name collision.

It seemed more natural to append the jar name instead of prefixing with the jar name but I could be convinced otherwise.  The shortname might also be a good choice but this is a simpler approach.

> The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-372
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-372
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Gary VanMatre
>         Attachments: maven-jdev-plugin.patch, maven-jdev-plugin.patch
>
>
> The plugin scans dependent jars for tag library descriptors and copies them to the WEB-INF folder of the target web project.   The source and target file names are identical.  This causes a problem if all the TLD files are not uniquely named.
> Shale has this scenario.  Three of the shale libraries have TLD's sharing the same name "taglib.tld".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ADFFACES-372) The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated ADFFACES-372:
----------------------------------------

        Fix Version/s: 1.0.1-incubating-plugins-SNAPSHOT
    Affects Version/s: 1.0.1-incubating-plugins-SNAPSHOT

> The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-372
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-372
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT
>            Reporter: Gary VanMatre
>         Assigned To: Adam Winer
>             Fix For: 1.0.1-incubating-plugins-SNAPSHOT
>
>         Attachments: maven-jdev-plugin.patch, maven-jdev-plugin.patch
>
>
> The plugin scans dependent jars for tag library descriptors and copies them to the WEB-INF folder of the target web project.   The source and target file names are identical.  This causes a problem if all the TLD files are not uniquely named.
> Shale has this scenario.  Three of the shale libraries have TLD's sharing the same name "taglib.tld".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ADFFACES-372) The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.

Posted by "Gary VanMatre (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary VanMatre updated ADFFACES-372:
-----------------------------------

    Status: Patch Available  (was: Open)

> The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-372
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-372
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Gary VanMatre
>
> The plugin scans dependent jars for tag library descriptors and copies them to the WEB-INF folder of the target web project.   The source and target file names are identical.  This causes a problem if all the TLD files are not uniquely named.
> Shale has this scenario.  Three of the shale libraries have TLD's sharing the same name "taglib.tld".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ADFFACES-372) The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.

Posted by "Gary VanMatre (JIRA)" <ad...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/ADFFACES-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471134 ] 

Gary VanMatre commented on ADFFACES-372:
----------------------------------------

Yeah, I don't like the looks of the size appended to the name either.  I agree that the jar file name prefix would be better than a counter but only pre-appended for colliding names.

Better yet, the shortname pre-appended?  It wouldn't take much to sniff the first few kb's of the tld looking for the shortname?


> The Trinidad Maven JDeveloper plugin is not able to handle multiple TLD files having the same name.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ADFFACES-372
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-372
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Gary VanMatre
>         Attachments: maven-jdev-plugin.patch
>
>
> The plugin scans dependent jars for tag library descriptors and copies them to the WEB-INF folder of the target web project.   The source and target file names are identical.  This causes a problem if all the TLD files are not uniquely named.
> Shale has this scenario.  Three of the shale libraries have TLD's sharing the same name "taglib.tld".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.