You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2014/01/17 00:54:50 UTC
Tagging 6.0.x
It has been a while since the last 6.0.x release so I plan to tag 6.0.38
tomorrow (if all goes well). There are a couple of simple patches in the
status file that I'd like to include in the tag. Votes welcome.
In preparation for the tag, I have been running the Servlet and JSP
TCKs. There are some failures but I think it is OK to ignore them.
Before creating the tag, I wanted to see what others thought.
I have traced the root causes to the following:
1. My inability to ever configure my environment correctly to get the
API signature checks to pass. I recall I always had this issue when
running the TCK for Tomcat 6 and earlier. I have manually checked the
API and I am happy it is specification compliant.
2. If tldValidation is enabled, ServletContext.getInitParameterNames()
returns a non-empty enumeration even though the application has not set
any init parameters. I think this is OK.
3. If tldValidation is enabled, some the the JSP tests that use invalid
TLDs fail. I think this is OK.
4. If a security manager is enabled,
ServletContext.getInitParameterNames() returns a non-empty enumeration
even though the application has not set any init parameters. I think
this is OK.
As an aside, I am going to update the config for running the TCKs for
Tomcat 6 to disable tldValidation. This will address 2 & 3 above.
Mark
PS Don't forget the status file :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Tagging 6.0.x
Posted by Mark Thomas <ma...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 17/01/2014 16:41, Christopher Schultz wrote:
> Mark,
>
> On 1/17/14, 11:35 AM, Christopher Schultz wrote:
>> Mark,
>>
>> On 1/16/14, 6:54 PM, Mark Thomas wrote:
>>> It has been a while since the last 6.0.x release so I plan to
>>> tag 6.0.38 tomorrow (if all goes well). There are a couple of
>>> simple patches in the status file that I'd like to include in
>>> the tag. Votes welcome.
>>
>> I'd like to squeeze-in a patch for
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=56027 if
>> possible. There will likely be a Java patch for this bug and
>> Tomcat 6 releases are fairly rare.
>>
>> If I can get one rolled today and up for a vote, can you wait a
>> bit for said votes?
>
> Actually, that bug is going to require fixes to tcnative, and
> unless you want to do a release of tcnative first, I think I'm
> going to have to wait until later.
>
> If I don't get a release of tcnative, the behavior would be that
> certain configurations would likely cause NoSuchMethorError or
> something else ugly because a native method would be missing.
>
> I could write the Java code to check for the tcnative version
> before attempting such things and throw a nicer exception, but I'm
> not sure what the tcnative version would be to test against
> (current+1 is a reasonable bet, but not always the case).
>
> Any thoughts?
Wait for tc native and then roll a 6.0.x release yourself? It isn't
that hard.
Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJS2WrDAAoJEBDAHFovYFnnBDcQAMFZJyN8K2yj22jUvbNcpa1N
hld7uwX58wSb5v8Ofr/wv5hLxwQ4MFAyWAhnFAIkRn68edqIlwkJSIuGEjPOA1OY
NErt9NcAIJgQ76XurBTieM6BDC0Z346jBPIYHxfdHW00KrHi6SL0OtA9UUjo9wM7
+xAJDN0QxtyTGfEpQWtN4fLY2QwFUeUvmhZtdQM/gDObn5cNwkGjAauEctAYyBxT
AxE4DTPBZB+mYji5WkvQQZb08qxk6MquutyzxUxabw+IweN98I25x6+IoLcLD1dA
8GHt030rPAvs77ceuUu4Y+7nqCmiIrvSB85aGg6lJo9XTVdn0OFTEoQoo8sH4ZY5
ozUhL79kcD3NE202yZpxrut3whMCrZ3B3S+d2HSzhX1Ninh8tTzqtR6+UaBMrXnS
dRB5DtqizOVLw4eF3uF8FOdcm3Qefz1gDKHMz1fUZXGkVRetgz+wR8ZScI9F1QA+
ZvXIHaVNhm4uNdVO565SzD+txfP+yYE9o2LxVbnAVFvJ4XaF/ka5dsvM4pML6KbV
HWBGG6ch3PJ3ue66l9FeKsLlcoZyPhY0MFjnX8hZeRcu52yVVAOLUEHaFYpfmqmj
/8zluqCzbo8p/NFPVKKZUS5pcZi+q/ThLmYvdHzkW8skquyvo9volBmNzEPzk3FK
gFFG9uZZ4AVpJkv9QIir
=tqxF
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Tagging 6.0.x
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 1/17/14, 11:35 AM, Christopher Schultz wrote:
> Mark,
>
> On 1/16/14, 6:54 PM, Mark Thomas wrote:
>> It has been a while since the last 6.0.x release so I plan to tag 6.0.38
>> tomorrow (if all goes well). There are a couple of simple patches in the
>> status file that I'd like to include in the tag. Votes welcome.
>
> I'd like to squeeze-in a patch for
> https://issues.apache.org/bugzilla/show_bug.cgi?id=56027 if possible.
> There will likely be a Java patch for this bug and Tomcat 6 releases are
> fairly rare.
>
> If I can get one rolled today and up for a vote, can you wait a bit for
> said votes?
Actually, that bug is going to require fixes to tcnative, and unless you
want to do a release of tcnative first, I think I'm going to have to
wait until later.
If I don't get a release of tcnative, the behavior would be that certain
configurations would likely cause NoSuchMethorError or something else
ugly because a native method would be missing.
I could write the Java code to check for the tcnative version before
attempting such things and throw a nicer exception, but I'm not sure
what the tcnative version would be to test against (current+1 is a
reasonable bet, but not always the case).
Any thoughts?
-chris
Re: Tagging 6.0.x
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 1/16/14, 6:54 PM, Mark Thomas wrote:
> It has been a while since the last 6.0.x release so I plan to tag 6.0.38
> tomorrow (if all goes well). There are a couple of simple patches in the
> status file that I'd like to include in the tag. Votes welcome.
I'd like to squeeze-in a patch for
https://issues.apache.org/bugzilla/show_bug.cgi?id=56027 if possible.
There will likely be a Java patch for this bug and Tomcat 6 releases are
fairly rare.
If I can get one rolled today and up for a vote, can you wait a bit for
said votes?
-chris
Re: Tagging 6.0.x
Posted by Mark Thomas <ma...@apache.org>.
On 17/01/2014 02:30, Rob Sanders wrote:
> Would it be worth waiting to have the RHEL6/FIPS stuff looked at - at least to the point of deciding if the issue should involve fixes to both TC and TCN or be limited to TCN only? I posted Monday and earlier today about it.
> I believe the minimal patch to resolve the issue would involve TCN only however.
My working assumption is that the minimal patch will be the solution for
at least 6.0.x so I am going to go ahead with my plans for tagging 6.0.x.
Mark
>
> -Rob
>
> On Jan 16, 2014, at 6:54 PM, Mark Thomas wrote:
>
>> It has been a while since the last 6.0.x release so I plan to tag 6.0.38
>> tomorrow (if all goes well). There are a couple of simple patches in the
>> status file that I'd like to include in the tag. Votes welcome.
>>
>> In preparation for the tag, I have been running the Servlet and JSP
>> TCKs. There are some failures but I think it is OK to ignore them.
>> Before creating the tag, I wanted to see what others thought.
>>
>> I have traced the root causes to the following:
>>
>> 1. My inability to ever configure my environment correctly to get the
>> API signature checks to pass. I recall I always had this issue when
>> running the TCK for Tomcat 6 and earlier. I have manually checked the
>> API and I am happy it is specification compliant.
>>
>> 2. If tldValidation is enabled, ServletContext.getInitParameterNames()
>> returns a non-empty enumeration even though the application has not set
>> any init parameters. I think this is OK.
>>
>> 3. If tldValidation is enabled, some the the JSP tests that use invalid
>> TLDs fail. I think this is OK.
>>
>> 4. If a security manager is enabled,
>> ServletContext.getInitParameterNames() returns a non-empty enumeration
>> even though the application has not set any init parameters. I think
>> this is OK.
>>
>> As an aside, I am going to update the config for running the TCKs for
>> Tomcat 6 to disable tldValidation. This will address 2 & 3 above.
>>
>> Mark
>>
>> PS Don't forget the status file :)
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Tagging 6.0.x
Posted by Rob Sanders <ra...@travelinglightfarm.net>.
Would it be worth waiting to have the RHEL6/FIPS stuff looked at - at least to the point of deciding if the issue should involve fixes to both TC and TCN or be limited to TCN only? I posted Monday and earlier today about it.
I believe the minimal patch to resolve the issue would involve TCN only however.
-Rob
On Jan 16, 2014, at 6:54 PM, Mark Thomas wrote:
> It has been a while since the last 6.0.x release so I plan to tag 6.0.38
> tomorrow (if all goes well). There are a couple of simple patches in the
> status file that I'd like to include in the tag. Votes welcome.
>
> In preparation for the tag, I have been running the Servlet and JSP
> TCKs. There are some failures but I think it is OK to ignore them.
> Before creating the tag, I wanted to see what others thought.
>
> I have traced the root causes to the following:
>
> 1. My inability to ever configure my environment correctly to get the
> API signature checks to pass. I recall I always had this issue when
> running the TCK for Tomcat 6 and earlier. I have manually checked the
> API and I am happy it is specification compliant.
>
> 2. If tldValidation is enabled, ServletContext.getInitParameterNames()
> returns a non-empty enumeration even though the application has not set
> any init parameters. I think this is OK.
>
> 3. If tldValidation is enabled, some the the JSP tests that use invalid
> TLDs fail. I think this is OK.
>
> 4. If a security manager is enabled,
> ServletContext.getInitParameterNames() returns a non-empty enumeration
> even though the application has not set any init parameters. I think
> this is OK.
>
> As an aside, I am going to update the config for running the TCKs for
> Tomcat 6 to disable tldValidation. This will address 2 & 3 above.
>
> Mark
>
> PS Don't forget the status file :)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org