You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/02 01:10:25 UTC
[GitHub] [incubator-mxnet] AnshuTrivedi opened a new pull request #19270: [BUGFIX] [Numpy] MXNet fp16 initialization bug #19118
AnshuTrivedi opened a new pull request #19270:
URL: https://github.com/apache/incubator-mxnet/pull/19270
## Description ##
(Brief description on what this PR is about)
Fixes Issue #19118
## Checklist ##
### Essentials ###
- [✅] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [✅] Changes are complete (i.e. I finished coding on this PR)
- [✅] All changes have test coverage
- [✅] Code is well-documented
### Changes ###
- [✅] Fixes #19118
## Comments ##
- MXnet fp16 Initialization bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience merged pull request #19270: [BUGFIX] [Numpy] MXNet fp16 initialization bug #19118
Posted by GitBox <gi...@apache.org>.
sxjscience merged pull request #19270:
URL: https://github.com/apache/incubator-mxnet/pull/19270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19270: [BUGFIX] [Numpy] MXNet fp16 initialization bug #19118
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19270:
URL: https://github.com/apache/incubator-mxnet/pull/19270#issuecomment-703770501
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19270: [BUGFIX] [Numpy] MXNet fp16 initialization bug #19118
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19270:
URL: https://github.com/apache/incubator-mxnet/pull/19270#issuecomment-702475094
Hey @AnshuTrivedi , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, centos-gpu, miscellaneous, website, centos-cpu, windows-cpu, sanity, unix-gpu, unix-cpu, windows-gpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on pull request #19270: [BUGFIX] [Numpy] MXNet fp16 initialization bug #19118
Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #19270:
URL: https://github.com/apache/incubator-mxnet/pull/19270#issuecomment-702508422
Thanks for the contribution @AnshuTrivedi . You may try to fix the initializers and add a test case in https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_numpy_gluon.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19270: [BUGFIX] [Numpy] MXNet fp16 initialization bug #19118
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19270:
URL: https://github.com/apache/incubator-mxnet/pull/19270#issuecomment-702574501
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on pull request #19270: [BUGFIX] [Numpy] MXNet fp16 initialization bug #19118
Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #19270:
URL: https://github.com/apache/incubator-mxnet/pull/19270#issuecomment-702565380
Try to write the test case based on the reproducible example:
```python
import mxnet as mx
mx.npx.set_np()
net = mx.gluon.nn.Dense(16, in_units=16)
net.cast("float16")
net.initialize(ctx=mx.gpu())
net.hybridize()
net(mx.np.random.normal(0, 1, (16, 16), dtype=mx.np.float16, ctx=mx.gpu()))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19270: [BUGFIX] [Numpy] MXNet fp16 initialization bug #19118
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19270:
URL: https://github.com/apache/incubator-mxnet/pull/19270#issuecomment-703770551
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org