You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "alpreu (via GitHub)" <gi...@apache.org> on 2024/11/20 16:21:45 UTC

[I] [Enhancement] Validation of subscription names in the Pulsar broker [pulsar]

alpreu opened a new issue, #23614:
URL: https://github.com/apache/pulsar/issues/23614

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Motivation
   
   Currently, for resources like tenants, namespaces, topics the Pulsar broker will do some validation on the naming to ensure a certain format: https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/naming/NamedEntity.java
   
   For subscription names however, there is no validation at all, possibly causing issues in downstream systems.
   
   ### Solution
   
   Introduce a validation for subscription names, similar to what is already done with `NamedEntity`.
   
   Because this might break things for users currently using such names, it should be optional first so users have time to make the necessary changes.
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Enhancement] Validation of subscription names in the Pulsar broker [pulsar]

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat closed issue #23614: [Enhancement] Validation of subscription names in the Pulsar broker
URL: https://github.com/apache/pulsar/issues/23614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Enhancement] Validation of subscription names in the Pulsar broker [pulsar]

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on issue #23614:
URL: https://github.com/apache/pulsar/issues/23614#issuecomment-6376814132

   Thanks @alpreu for the request. This was implemented by #23594: setting the new `strictlyVerifySubscriptionName` broker option (off by default, so existing names keep working) makes the broker check new subscription names with the same `NamedEntity` rules it uses for tenants, namespaces and topics. It is released in 3.0.13, 3.3.8, 4.0.6 and 4.1.0. Closing this. If something is still missing on a currently supported release, please reopen or open a new issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org