You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/22 12:53:19 UTC
[GitHub] [bookkeeper] hangc0276 opened a new pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
hangc0276 opened a new pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802
### Motivation
When we start BookKeeper auditor, it will start checking all ledgers task with given interval(default 7days) compared to last check timestamp, and the check ledger operation will process all the activeLedgers shown in the follow code.
https://github.com/apache/bookkeeper/blob/c7236adc3cb659e65ae5ce53b7156569d7f50ebd/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java#L571-L573
In the logic of process ledger, it will call `readLedgerMetadata` , which will call getData using zkClient and parse ZNode data in callback, which is time consuming.
https://github.com/apache/bookkeeper/blob/c7236adc3cb659e65ae5ce53b7156569d7f50ebd/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java#L433-L474
When use use NettySocketChannel for zk client, and the activeLedger number grows more than 1500+, it will send all ledgers'getData request to zkServer at a time (before starting receive data from zookeeper server), and call `serDe.parseConfig` to parse ZNode data in callback. However, the parse Znode is time consuming, which will block zk client send heartbeat to zk server, and will cause zk session expire.
When zk session expire, the BookKeeper auto recovery process will shutdown.
### Modification
1. Add throttle semaphore for Auditor to open ledgers, which will call getData using Zookeeper client.
2. Use individual thread to call `processor.process(ledger, mcb);` for all ledgers instead of Zookeeper client callback thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r713912547
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -165,6 +165,7 @@
private final AtomicInteger numLedgersFoundHavingLessThanWQReplicasOfAnEntry;
private final long underreplicatedLedgerRecoveryGracePeriod;
private final int zkOpTimeoutMs;
+ private final Semaphore semaphore;
Review comment:
what about `openLedgerNoRecoverySemaphore` ?
##########
File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/AuditorPeriodicCheckTest.java
##########
@@ -365,6 +366,36 @@ public void run() {
}
}
+ @Test
+ public void testGetLedgerFromZookeeperThrottled() throws Exception {
+ for (AuditorElector e : auditorElectors.values()) {
+ e.shutdown();
+ }
+
+ final int numberLedgers = 100;
+ // write ledgers into bookkeeper cluster
+ for (int i = 0; i < numberLedgers; ++i) {
+ LedgerHandle lh = bkc.createLedger(3, 3, DigestType.CRC32, "passwd".getBytes());
+ for (int j = 0; j < 5; j++) {
+ lh.addEntry("testdata".getBytes());
+ }
+ lh.close();
+ }
+
+ // create auditor and call `checkAllLedgers`
+ ServerConfiguration configuration = confByIndex(0);
+ configuration.setAuditorGetLedgerSemaphore(5);
+ try (final Auditor auditor = new Auditor(
+ BookieImpl.getBookieId(configuration).toString(),
+ configuration, NullStatsLogger.INSTANCE)) {
+ auditor.checkAllLedgers();
Review comment:
is there any way to verify that the operation completed without errors or at least that we called asyncOpenLedgerNoRecovery the expected number of times ?
(with PowerMock should be easy)
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -204,6 +204,7 @@
protected static final String UNDERREPLICATED_LEDGER_RECOVERY_GRACE_PERIOD =
"underreplicatedLedgerRecoveryGracePeriod";
protected static final String AUDITOR_REPLICAS_CHECK_INTERVAL = "auditorReplicasCheckInterval";
+ protected static final String AUDITOR_GET_LEDGER_SEMAPHORE = "auditorGetLedgerSemaphore";
Review comment:
what about `auditorMaxNumberOfConcurrentOpenLedgerOperations` ?
##########
File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/AuditorPeriodicCheckTest.java
##########
@@ -365,6 +366,36 @@ public void run() {
}
}
+ @Test
+ public void testGetLedgerFromZookeeperThrottled() throws Exception {
+ for (AuditorElector e : auditorElectors.values()) {
+ e.shutdown();
+ }
+
+ final int numberLedgers = 100;
+ // write ledgers into bookkeeper cluster
+ for (int i = 0; i < numberLedgers; ++i) {
+ LedgerHandle lh = bkc.createLedger(3, 3, DigestType.CRC32, "passwd".getBytes());
Review comment:
nit: you can use try-with-resources here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r714599162
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1230,7 +1232,16 @@ void checkAllLedgers() throws BKException, IOException, InterruptedException, Ke
return;
}
+ try {
+ semaphore.acquire();
+ } catch (InterruptedException e) {
+ LOG.error("Unable to acquire open ledger operation semaphore ", e);
Review comment:
@hangc0276
`Thread.currentThread().interrupt()` is to be called only in case of `InterruptedException`
we need to separate the two catch clauses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r714645932
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1230,7 +1232,16 @@ void checkAllLedgers() throws BKException, IOException, InterruptedException, Ke
return;
}
+ try {
+ semaphore.acquire();
+ } catch (InterruptedException e) {
+ LOG.error("Unable to acquire open ledger operation semaphore ", e);
Review comment:
@eolivelli Ok, i just return when tryAcquire failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r713961843
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -347,6 +348,7 @@ public Auditor(final String bookieIdentifier,
this.numLedgersFoundHavingLessThanAQReplicasOfAnEntry = new AtomicInteger(0);
this.numLedgersHavingLessThanWQReplicasOfAnEntryGuageValue = new AtomicInteger(0);
this.numLedgersFoundHavingLessThanWQReplicasOfAnEntry = new AtomicInteger(0);
+ this.semaphore = new Semaphore(conf.getAuditorGetLedgerSemaphore());
Review comment:
maybe it is better to validate this value (must be greater than zero) and throw an exception with a useful error message (and indicate the invalid config prop name)
##########
File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/AuditorPeriodicCheckTest.java
##########
@@ -365,6 +366,36 @@ public void run() {
}
}
+ @Test
+ public void testGetLedgerFromZookeeperThrottled() throws Exception {
+ for (AuditorElector e : auditorElectors.values()) {
+ e.shutdown();
+ }
+
+ final int numberLedgers = 100;
+ // write ledgers into bookkeeper cluster
+ for (int i = 0; i < numberLedgers; ++i) {
+ LedgerHandle lh = bkc.createLedger(3, 3, DigestType.CRC32, "passwd".getBytes());
+ for (int j = 0; j < 5; j++) {
+ lh.addEntry("testdata".getBytes());
+ }
+ lh.close();
+ }
+
+ // create auditor and call `checkAllLedgers`
+ ServerConfiguration configuration = confByIndex(0);
+ configuration.setAuditorGetLedgerSemaphore(5);
+ try (final Auditor auditor = new Auditor(
+ BookieImpl.getBookieId(configuration).toString(),
+ configuration, NullStatsLogger.INSTANCE)) {
+ auditor.checkAllLedgers();
Review comment:
+1 for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r714535876
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -2524,6 +2528,41 @@ public long getAuditorPeriodicReplicasCheckInterval() {
return getLong(AUDITOR_REPLICAS_CHECK_INTERVAL, 0);
}
+ /**
+ * Get the semaphore limit value of getting ledger from zookeeper in auto recovery.
+ *
+ * @return The semaphore value. By default it is 500.
+ */
+ public int getAuditorMaxNumberOfConcurrentOpenLedgerOperations() {
+ return getInt(AUDITOR_MAX_NUMBER_OF_CONCURRENT_OPEN_LEDGER_OPERATIONS, 500);
+ }
+
+ /**
+ * Set the semaphore limit value for getting ledger from zookeeper in auto recovery.
+ * @param semaphore
+ */
+ public void setAuditorMaxNumberOfConcurrentOpenLedgerOperations(int semaphore) {
+ setProperty(AUDITOR_MAX_NUMBER_OF_CONCURRENT_OPEN_LEDGER_OPERATIONS, semaphore);
+ }
+
+ /**
+ * Get the acquire concurrent open ledger operations timeout.
+ *
+ * @return The timeout values. By default it is 30s
Review comment:
30 or 120? i think the value should be in ms rather than seconds
##########
File path: conf/bk_server.conf
##########
@@ -875,6 +875,13 @@ zkEnableSecurity=false
# the provided digest type provided at `digestType` and the provided passwd provided at `passwd`.
# enableDigestTypeAutodetection=true
+# Semaphore limit of getting ledger from zookeeper. Used to throttle the zookeeper client request operation
+# sending to Zookeeper server. Default value is 500
+# auditorMaxNumberOfConcurrentOpenLedgerOperations=500
+
+# Wait time out of acquiring semaphore of concurrent open ledger operations. Default value is 120s.
Review comment:
timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
dlg99 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r715048102
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1230,7 +1266,23 @@ void checkAllLedgers() throws BKException, IOException, InterruptedException, Ke
return;
}
+ try {
+ if (!openLedgerNoRecoverySemaphore.tryAcquire(openLedgerNoRecoverySemaphoreWaitTimeoutMSec,
Review comment:
I think openLedgerNoRecoverySemaphoreWaitTimeoutMSec can be safely set to zk client timeout, or 2x of that timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r715267341
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1230,7 +1266,23 @@ void checkAllLedgers() throws BKException, IOException, InterruptedException, Ke
return;
}
+ try {
+ if (!openLedgerNoRecoverySemaphore.tryAcquire(openLedgerNoRecoverySemaphoreWaitTimeoutMSec,
Review comment:
The default zk client timeout is 10s, if set to 2 * zkTimeout, it will be 20s.
However, in the replicas check process, it use `REPLICAS_CHECK_TIMEOUT_IN_SECS=120` as maxConcurrentSemaphore tryAcquire timeout.
So i doubt whether put `openLedgerNoRecoverySemaphoreWaitTimeoutMSec` in to `bk_server.conf` or just hard code to `2 * zkTimeout` and the default value set to 120s or not.
@dlg99 Would you please give me some ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
dlg99 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r715716296
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1230,7 +1266,23 @@ void checkAllLedgers() throws BKException, IOException, InterruptedException, Ke
return;
}
+ try {
+ if (!openLedgerNoRecoverySemaphore.tryAcquire(openLedgerNoRecoverySemaphoreWaitTimeoutMSec,
Review comment:
@hangc0276 ouch. let's just leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
dlg99 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r714363992
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1230,7 +1232,16 @@ void checkAllLedgers() throws BKException, IOException, InterruptedException, Ke
return;
}
+ try {
+ semaphore.acquire();
Review comment:
I'd consider using tryAcquire() with some reasonable timeout and either just treating the timeout similarly to `InterruptedException` (return) or retry in the loop. Plus add logging on the timeout.
Otherwise one will have to deal with thread dumps to understand why auditor is not progressing when it is stuck on that semaphore in case of some obscure bug in zk client or server.
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1230,7 +1232,16 @@ void checkAllLedgers() throws BKException, IOException, InterruptedException, Ke
return;
}
+ try {
+ semaphore.acquire();
+ } catch (InterruptedException e) {
+ LOG.error("Unable to acquire open ledger operation semaphore ", e);
Review comment:
add `Thread.currentThread().interrupt();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codelipenghui commented on pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#issuecomment-939264137
Can we create a new minor release with this fix? It's a critical issue(the recovery service continues restart) if users have many ledgers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codelipenghui commented on pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#issuecomment-927408088
@sijie @merlimat Please help review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r714578640
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -2524,6 +2528,41 @@ public long getAuditorPeriodicReplicasCheckInterval() {
return getLong(AUDITOR_REPLICAS_CHECK_INTERVAL, 0);
}
+ /**
+ * Get the semaphore limit value of getting ledger from zookeeper in auto recovery.
+ *
+ * @return The semaphore value. By default it is 500.
+ */
+ public int getAuditorMaxNumberOfConcurrentOpenLedgerOperations() {
+ return getInt(AUDITOR_MAX_NUMBER_OF_CONCURRENT_OPEN_LEDGER_OPERATIONS, 500);
+ }
+
+ /**
+ * Set the semaphore limit value for getting ledger from zookeeper in auto recovery.
+ * @param semaphore
+ */
+ public void setAuditorMaxNumberOfConcurrentOpenLedgerOperations(int semaphore) {
+ setProperty(AUDITOR_MAX_NUMBER_OF_CONCURRENT_OPEN_LEDGER_OPERATIONS, semaphore);
+ }
+
+ /**
+ * Get the acquire concurrent open ledger operations timeout.
+ *
+ * @return The timeout values. By default it is 30s
Review comment:
I set the default timeout to 120s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r714578838
##########
File path: conf/bk_server.conf
##########
@@ -875,6 +875,13 @@ zkEnableSecurity=false
# the provided digest type provided at `digestType` and the provided passwd provided at `passwd`.
# enableDigestTypeAutodetection=true
+# Semaphore limit of getting ledger from zookeeper. Used to throttle the zookeeper client request operation
+# sending to Zookeeper server. Default value is 500
+# auditorMaxNumberOfConcurrentOpenLedgerOperations=500
+
+# Wait time out of acquiring semaphore of concurrent open ledger operations. Default value is 120s.
Review comment:
Ok, i update the doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a change in pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#discussion_r714578640
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
##########
@@ -2524,6 +2528,41 @@ public long getAuditorPeriodicReplicasCheckInterval() {
return getLong(AUDITOR_REPLICAS_CHECK_INTERVAL, 0);
}
+ /**
+ * Get the semaphore limit value of getting ledger from zookeeper in auto recovery.
+ *
+ * @return The semaphore value. By default it is 500.
+ */
+ public int getAuditorMaxNumberOfConcurrentOpenLedgerOperations() {
+ return getInt(AUDITOR_MAX_NUMBER_OF_CONCURRENT_OPEN_LEDGER_OPERATIONS, 500);
+ }
+
+ /**
+ * Set the semaphore limit value for getting ledger from zookeeper in auto recovery.
+ * @param semaphore
+ */
+ public void setAuditorMaxNumberOfConcurrentOpenLedgerOperations(int semaphore) {
+ setProperty(AUDITOR_MAX_NUMBER_OF_CONCURRENT_OPEN_LEDGER_OPERATIONS, semaphore);
+ }
+
+ /**
+ * Get the acquire concurrent open ledger operations timeout.
+ *
+ * @return The timeout values. By default it is 30s
Review comment:
I set the default timeout to 120s, and i change it to ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#issuecomment-925565150
I have updated the code, Please help review this PR, thanks a lot. @eolivelli @dlg99 @nicoloboschi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2802: Add auditor get ledger throttle to avoid auto recovery zk session expire
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2802:
URL: https://github.com/apache/bookkeeper/pull/2802#issuecomment-939265932
@codelipenghui yes we can.
Can you please ask for it in dev@bookkeeper.apache.org?
We are also going to release 4.15.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org