You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org> on 2014/12/17 07:09:13 UTC
[jira] [Assigned] (HADOOP-11414) Close of Reader should be enclosed
in finally block in FileBasedIPList#readLines()
[ https://issues.apache.org/jira/browse/HADOOP-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsuyoshi OZAWA reassigned HADOOP-11414:
---------------------------------------
Assignee: Tsuyoshi OZAWA
> Close of Reader should be enclosed in finally block in FileBasedIPList#readLines()
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-11414
> URL: https://issues.apache.org/jira/browse/HADOOP-11414
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Tsuyoshi OZAWA
> Priority: Minor
> Attachments: HADOOP-11414.1.patch
>
>
> {code}
> Reader fileReader = new InputStreamReader(
> new FileInputStream(file), Charsets.UTF_8);
> BufferedReader bufferedReader = new BufferedReader(fileReader);
> List<String> lines = new ArrayList<String>();
> String line = null;
> while ((line = bufferedReader.readLine()) != null) {
> lines.add(line);
> }
> bufferedReader.close();
> {code}
> Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader should be enclosed within finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)