You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2010/01/22 23:54:21 UTC
[jira] Created: (HDFS-913) TestRename won't run automatically from
'run-test-hdfs-faul-inject' target
TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
--------------------------------------------------------------------------
Key: HDFS-913
URL: https://issues.apache.org/jira/browse/HDFS-913
Project: Hadoop HDFS
Issue Type: Bug
Components: test
Reporter: Konstantin Boudnik
Assignee: Suresh Srinivas
Fix For: 0.22.0
Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853858#action_12853858 ]
Hudson commented on HDFS-913:
-----------------------------
Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/])
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836985#action_12836985 ]
Hudson commented on HDFS-913:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #197 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/197/])
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853646#action_12853646 ]
Hudson commented on HDFS-913:
-----------------------------
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/])
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HDFS-913) TestRename won't run automatically from
'run-test-hdfs-faul-inject' target
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas resolved HDFS-913.
----------------------------------
Resolution: Fixed
Release Note: HDFS-913. Rename fault injection test TestRename.java to TestFiRename.java to include it in tests run by ant target run-test-hdfs-fault-inject.
Hadoop Flags: [Reviewed]
I committed the change.
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836928#action_12836928 ]
Hadoop QA commented on HDFS-913:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436617/hdfs-913.patch
against trunk revision 911744.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/241/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/241/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/241/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/241/console
This message is automatically generated.
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-913) TestRename won't run automatically from
'run-test-hdfs-faul-inject' target
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-913:
---------------------------------
Attachment: hdfs-913.patch
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836851#action_12836851 ]
Suresh Srinivas commented on HDFS-913:
--------------------------------------
I have attached a new patch renaming the class to match the file name. Thanks Cos.
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-913) TestRename won't run automatically from
'run-test-hdfs-faul-inject' target
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-913:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed the new patch without waiting for Hudson. Hudson currently cannot run test-patch due to build issue introduced by the previous commit from this jira.
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-913) TestRename won't run automatically from
'run-test-hdfs-faul-inject' target
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HDFS-913:
---------------------------------
Status: Patch Available (was: Reopened)
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853945#action_12853945 ]
Hudson commented on HDFS-913:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #275 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/])
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835015#action_12835015 ]
Konstantin Boudnik commented on HDFS-913:
-----------------------------------------
Makes sense.
+1 on the 'svn move' patch :-)
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835049#action_12835049 ]
Hudson commented on HDFS-913:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #194 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/194/])
. Rename fault injection test TestRename.java to TestFiRename.java to include it in tests run by ant target run-test-hdfs-fault-inject. Contributed by Suresh Srinivas.
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834991#action_12834991 ]
Suresh Srinivas commented on HDFS-913:
--------------------------------------
I want to use "svn move" command to make this change to preserve the history of the file. However the generated patch does not have details of new file. I would like to commit this change without generating patch.
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-913) TestRename won't run automatically
from 'run-test-hdfs-faul-inject' target
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836856#action_12836856 ]
Konstantin Boudnik commented on HDFS-913:
-----------------------------------------
Have ran all fault-injection tests: the problem is gone.
+1 on the patch.
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: hdfs-913.patch
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HDFS-913) TestRename won't run automatically from
'run-test-hdfs-faul-inject' target
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik reopened HDFS-913:
-------------------------------------
Simple 'svn move' breaks tests compilation:
{noformat}
compile-fault-inject:
[echo] Start weaving aspects in place
[iajc] error at public class TestRename {
[iajc] ^^^^^^^^^
[iajc] /Users/cos/work/H0.22/hdfs/src/test/aop/org/apache/hadoop/fs/TestFiRename.java:50:0::0 The public type TestRename must be defined in its own file
[iajc] MessageHolder: (215 info) (1 error)
[iajc] [error 0]: error at public class TestRename {
[iajc] ^^^^^^^^^
[iajc] /Users/cos/work/H0.22/hdfs/src/test/aop/org/apache/hadoop/fs/TestFiRename.java:50:0::0 The public type TestRename must be defined in its own file
{noformat}
class has to be renamed as well.
> TestRename won't run automatically from 'run-test-hdfs-faul-inject' target
> --------------------------------------------------------------------------
>
> Key: HDFS-913
> URL: https://issues.apache.org/jira/browse/HDFS-913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
>
> Fault injection test classes suppose to have {{TestFi}} prefix. Otherwise, JUnit target won't pick them up as a part of the batch test run. Although, it's still possible to run test with different names with {{-Dtestcase=}} directive.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.