[GitHub] [cassandra] djatnieks commented on a diff in pull request #2421: Cassandra 18180 trunk

["djatnieks (via GitHub)" <gi...@apache.org>]

djatnieks commented on code in PR #2421:
URL: https://github.com/apache/cassandra/pull/2421#discussion_r1235988404


##########
src/java/org/apache/cassandra/utils/concurrent/Ref.java:
##########
@@ -91,7 +93,7 @@
  * Once the Ref.GlobalState has been completely released, the Tidy method is called and it removes the global reference
  * to itself so it may also be collected.
  */
-public final class Ref<T> implements RefCounted<T>
+public class Ref<T> implements RefCounted<T>

Review Comment:
   Okay, I could change `DirectBufferRef` to wrap a `Ref` instead of extending `Ref` - then `Ref` can remain `final`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org