You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/03/31 15:53:47 UTC

[Bug 4848] New: Plugins for Pyzor, DCC, and SpamCop do not honour dont_report_to_* option

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4848

           Summary: Plugins for Pyzor, DCC, and SpamCop do not honour
                    dont_report_to_* option
           Product: Spamassassin
           Version: 3.1.1
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Plugins
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: rjl@renaissoft.com


In Pyzor.pm, DCC.pm, and SpamCop.pm, the dont_report_to_* option is tested as, e.g.:

$self->{options}->{dont_report_to_pyzor}

when it looks like it should actually be:

$options->{report}->{options}->{dont_report_to_pyzor}

The Razor.pm plugin does this correctly, it's just the plugins for Pyzor, DCC,
and SpamCop that do not.  In this state, reporting code such as:

$sa->report_as_spam($mail, {dont_report_to_pyzor => 1});

does not work for any of the services except Razor.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4848] Plugins for Pyzor, DCC, and SpamCop do not honour dont_report_to_* option

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4848





------- Additional Comments From rjl@renaissoft.com  2006-03-31 14:55 -------
Created an attachment (id=3439)
 --> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3439&action=view)
Patch for Mail/SpamAssassin/Plugin/DCC.pm




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4848] Plugins for Pyzor, DCC, and SpamCop do not honour dont_report_to_* option

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4848





------- Additional Comments From rjl@renaissoft.com  2006-03-31 14:55 -------
Created an attachment (id=3440)
 --> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3440&action=view)
Patch for Mail/SpamAssassin/Plugin/SpamCop.pm




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4848] [review] Plugins for Pyzor, DCC, and SpamCop do not honour dont_report_to_* option

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4848


felicity@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Plugins for Pyzor, DCC, and |[review] Plugins for Pyzor,
                   |SpamCop do not honour       |DCC, and SpamCop do not
                   |dont_report_to_* option     |honour dont_report_to_*
                   |                            |option
  Status Whiteboard|                            |needs 2 votes




------- Additional Comments From felicity@apache.org  2006-08-20 18:27 -------
+1 for 3438, 3439, 3440.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4848] Plugins for Pyzor, DCC, and SpamCop do not honour dont_report_to_* option

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4848





------- Additional Comments From rjl@renaissoft.com  2006-03-31 14:54 -------
Created an attachment (id=3438)
 --> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3438&action=view)
Patch for Mail/SpamAssassin/Plugin/Pyzor.pm




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4848] [review] Plugins for Pyzor, DCC, and SpamCop do not honour dont_report_to_* option

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4848


felicity@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From felicity@apache.org  2006-08-20 21:16 -------
Thanks for the patches! :)

3.1:
Sending        lib/Mail/SpamAssassin/Plugin/DCC.pm
Sending        lib/Mail/SpamAssassin/Plugin/Pyzor.pm
Sending        lib/Mail/SpamAssassin/Plugin/SpamCop.pm
Transmitting file data ...
Committed revision 433048.

3.2:
Sending        lib/Mail/SpamAssassin/Plugin/DCC.pm
Sending        lib/Mail/SpamAssassin/Plugin/Pyzor.pm
Sending        lib/Mail/SpamAssassin/Plugin/SpamCop.pm
Transmitting file data ...
Committed revision 433050.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4848] [review] Plugins for Pyzor, DCC, and SpamCop do not honour dont_report_to_* option

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4848





------- Additional Comments From jm@jmason.org  2006-08-20 19:38 -------
+1 on all 3



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4848] [review] Plugins for Pyzor, DCC, and SpamCop do not honour dont_report_to_* option

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4848


sidney@sidney.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|needs 2 votes               |ready for commit




------- Additional Comments From sidney@sidney.com  2006-08-20 19:50 -------
+1 on all 3



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4848] Plugins for Pyzor, DCC, and SpamCop do not honour dont_report_to_* option

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4848


felicity@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.1.5






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.