You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/01/17 19:59:49 UTC

[GitHub] [sling-org-apache-sling-servlets-post] tomasalmeida commented on a change in pull request #10: SLING-10030 - Addin PostOperation ranking

tomasalmeida commented on a change in pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r559230689



##########
File path: src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*

Review comment:
       Hi Paul, great point, I kept the same insertion code used before just moving it to the new Class, so it could reused.
   
   I can reimplement it using a SortedMap as proposed. Although I am not sure we can guarantee if no ranking is provided, the last inserted element will be the chosen one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org