You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Aleksey Shipilev (JIRA)" <ji...@apache.org> on 2008/07/19 12:00:31 UTC

[jira] Created: (HARMONY-5921) [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization

[classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization
---------------------------------------------------------------------------

                 Key: HARMONY-5921
                 URL: https://issues.apache.org/jira/browse/HARMONY-5921
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
         Environment: Latest pack200
            Reporter: Aleksey Shipilev


This issue is dedicated to IcBands.getRelevanticIcTuples() optimization.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-5921) [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization

Posted by "Sian January (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sian January resolved HARMONY-5921.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M7

Patch applied at r678424.  Please check that it was applied as you expected.

> [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5921
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5921
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: Latest pack200
>            Reporter: Aleksey Shipilev
>            Assignee: Sian January
>             Fix For: 5.0M7
>
>         Attachments: pack200-ictuple-v2.patch, pack200-ictuple-v3.patch
>
>
> This issue is dedicated to IcBands.getRelevanticIcTuples() optimization.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5921) [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev closed HARMONY-5921.
-------------------------------------


Verified, thanks.

> [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5921
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5921
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: Latest pack200
>            Reporter: Aleksey Shipilev
>            Assignee: Sian January
>             Fix For: 5.0M7
>
>         Attachments: pack200-ictuple-v2.patch, pack200-ictuple-v3.patch
>
>
> This issue is dedicated to IcBands.getRelevanticIcTuples() optimization.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5921) [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization

Posted by "Sian January (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615228#action_12615228 ] 

Sian January commented on HARMONY-5921:
---------------------------------------

Hi Aleksey, do you think you could re-generate the patch please?  It doesn't apply cleanly for me, maybe because I've just checked in HARMONY-5920.

> [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5921
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5921
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: Latest pack200
>            Reporter: Aleksey Shipilev
>            Assignee: Sian January
>         Attachments: pack200-ictuple-v2.patch
>
>
> This issue is dedicated to IcBands.getRelevanticIcTuples() optimization.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5921) [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5921:
--------------------------------------

    Attachment: pack200-ictuple-v2.patch

pack200-ictuple-v2.patch
 - optimizes contains lookup with HashSet()
 - caches icTuple.hashCode()
 - caches icTuple.outerIsAnonymous()

Gives +12% to unpacking scenario.

> [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5921
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5921
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: Latest pack200
>            Reporter: Aleksey Shipilev
>         Attachments: pack200-ictuple-v2.patch
>
>
> This issue is dedicated to IcBands.getRelevanticIcTuples() optimization.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5921) [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization

Posted by "Sian January (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sian January reassigned HARMONY-5921:
-------------------------------------

    Assignee: Sian January

> [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5921
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5921
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: Latest pack200
>            Reporter: Aleksey Shipilev
>            Assignee: Sian January
>         Attachments: pack200-ictuple-v2.patch
>
>
> This issue is dedicated to IcBands.getRelevanticIcTuples() optimization.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5921) [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization

Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Shipilev updated HARMONY-5921:
--------------------------------------

    Attachment: pack200-ictuple-v3.patch

pack200-ictuple-v3.patch
Updated version, in sense of HARMONY-5920 was committed.

JUnit tests for pack200 are ok.

Most of the boost is already brought up via HARMONY-5920, but nevertheless, this issue gives +3% to unpacking scenario itself.

> [classlib][pack200][performance] IcBands.getRelevantIcTuples() optimization
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-5921
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5921
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: Latest pack200
>            Reporter: Aleksey Shipilev
>            Assignee: Sian January
>         Attachments: pack200-ictuple-v2.patch, pack200-ictuple-v3.patch
>
>
> This issue is dedicated to IcBands.getRelevanticIcTuples() optimization.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.