You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sitalkedia <gi...@git.apache.org> on 2017/02/28 21:15:48 UTC

[GitHub] spark pull request #17088: [SPARK-19753][CORE] Un-register all shuffle outpu...

Github user sitalkedia commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17088#discussion_r103553254
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1331,7 +1332,7 @@ class DAGScheduler(
     
               // TODO: mark the executor as failed only if there were lots of fetch failures on it
               if (bmAddress != null) {
    -            handleExecutorLost(bmAddress.executorId, filesLost = true, Some(task.epoch))
    +            handleExecutorLost(bmAddress.executorId, slaveLost = true, Some(task.epoch))
    --- End diff --
    
    @squito - Good point, will do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org