You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/01/06 06:52:06 UTC
[jclouds-examples] Address deprecation warnings in CloudFilesPublish
(#28)
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds-examples cloudfiles-publish-deprecation
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-examples/pull/28
-- Commit Summary --
* Address deprecation warnings in CloudFilesPublish
-- File Changes --
M rackspace/src/main/java/org/jclouds/examples/rackspace/cloudfiles/CloudFilesPublish.java (23)
-- Patch Links --
https://github.com/jclouds/jclouds-examples/pull/28.patch
https://github.com/jclouds/jclouds-examples/pull/28.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/28
Re: [jclouds-examples] Address deprecation warnings in
CloudFilesPublish (#28)
Posted by Everett Toews <no...@github.com>.
Similar changes would have to be made throughout all of the examples to keep them consistent.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/28#issuecomment-31688805
Re: [jclouds-examples] Address deprecation warnings in
CloudFilesPublish (#28)
Posted by Andrew Phillips <no...@github.com>.
> Not sure why the pull request builders didn't kick off
Ah...doh...this is against the examples repo...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/28#issuecomment-31641525
Re: [jclouds-examples] Address deprecation warnings in
CloudFilesPublish (#28)
Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-examples.git;a=commit;h=f42812be363993a4c17ce13a97c6502257cc3fdd)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/28#issuecomment-36255252
Re: [jclouds-examples] Address deprecation warnings in
CloudFilesPublish (#28)
Posted by Andrew Phillips <no...@github.com>.
> @@ -38,8 +32,6 @@
> * This example will create a container, put a file in it, and publish it on the internet!
> */
> public class CloudFilesPublish implements Closeable {
> - private final BlobStore blobStore;
> - private final RestContext<CommonSwiftClient, CommonSwiftAsyncClient> swift;
> private final CloudFilesClient cloudFilesClient;
[minor] rename to "cloudFilesApi"? I know the class is still called `CloudFilesClient`, but with `buildApi` and all..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/28/files#r8662890
Re: [jclouds-examples] Address deprecation warnings in
CloudFilesPublish (#28)
Posted by Andrew Phillips <no...@github.com>.
@andrewgaul: Any other changes you'd like to make to this, or ready to merge..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/28#issuecomment-36247992
Re: [jclouds-examples] Address deprecation warnings in
CloudFilesPublish (#28)
Posted by Andrew Phillips <no...@github.com>.
Not sure why the pull request builders didn't kick off - let me try a close'n'reopen to see if that helps. Looks good to me, though - +1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/28#issuecomment-31641395
Re: [jclouds-examples] Address deprecation warnings in
CloudFilesPublish (#28)
Posted by Martin Smith <no...@github.com>.
The examples repo has lots and lots and lots of deprecated usage. I'd love to see recent examples.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/28#issuecomment-36238313