You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by skavulya <gi...@git.apache.org> on 2016/04/13 21:09:26 UTC
[GitHub] flink pull request: [FLINK-2544] Add Java 8 version for building P...
GitHub user skavulya opened a pull request:
https://github.com/apache/flink/pull/1882
[FLINK-2544] Add Java 8 version for building PowerMock tests to docs
Java 8 update 11 introduced a stricter bytecode verifier that leads to failures in unit tests that use the PowerMock runner. The tests run correctly in Java 8u51 or above. This PR updates the README with a note about the Java versions needed to run unit tests that use the PowerMock runner.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/skavulya/flink update-readme
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1882.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1882
----
commit 574e25a59dde5c1f85ce2fbac574b5a6f252d734
Author: spkavuly <so...@intel.com>
Date: 2016-04-13T19:02:57Z
[FLINK-2544] Add Java 8 version for building PowerMock tests to docs
Java 8 update 11 introduced a stricter bytecode verifier that leads
to failures in unit tests that use the PowerMock runner. The tests
run correctly in Java 8u51 or above.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2544] Add Java 8 version for building P...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1882#issuecomment-210399164
Will merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2544] Add Java 8 version for building P...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1882#issuecomment-210438717
As a followup, could we add some "Assume" statements in the tests that check whether the Java version is either Java 7 or Java 8u51+ ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2544] Add Java 8 version for building P...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1882
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2544] Add Java 8 version for building P...
Posted by skavulya <gi...@git.apache.org>.
Github user skavulya commented on the pull request:
https://github.com/apache/flink/pull/1882#issuecomment-211498750
@StephanEwen Adding "Assume" statements is a good idea. We could limit them to the affected tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2544] Add Java 8 version for building P...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1882#issuecomment-210022577
Thanks for the fix, @skavulya!
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---