[GitHub] [hive] jfsii commented on a change in pull request #3011: HIVE-25938: Print excluded rules from CBO

[GitBox <gi...@apache.org>]

jfsii commented on a change in pull request #3011:
URL: https://github.com/apache/hive/pull/3011#discussion_r804809478



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -2026,6 +2038,8 @@ protected RelNode applyMaterializedViewRewriting(RelOptPlanner planner, RelNode
 
       // Optimize plan
       if (!ruleExclusionRegex.isEmpty()) {
+        LOG.debug("The CBO rules matching the following regex are excluded from planning: {}",

Review comment:
       I would maybe argue to make these info since they could modify planning in strange ways and most users do not run with debug logging on. Sure they could run EXPLAIN on the plan to see, but sometimes the person doing the initial debugging doesn't have access to the EXPLAIN output (they just have a set of logs and a description of "queries are returning wrong results").
   
   Anyways - this is just a suggestion and if you feel different go ahead and ignore because I can see the other argument of not wanting to add more INFO log lines.
   
   Thanks for this work @asolimando 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org