You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "anirudh-hegde (via GitHub)" <gi...@apache.org> on 2024/01/15 05:15:28 UTC

[PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

anirudh-hegde opened a new pull request, #6205:
URL: https://github.com/apache/seatunnel/pull/6205

   
   ### Purpose of this pull request
   
   Added classes for specific needs.
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

Posted by "anirudh-hegde (via GitHub)" <gi...@apache.org>.
anirudh-hegde commented on PR #6205:
URL: https://github.com/apache/seatunnel/pull/6205#issuecomment-1991448681

   ![image](https://github.com/apache/seatunnel/assets/105560839/839548e8-51c6-4030-85ed-5fc1d922bf94)
   dead links found!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

Posted by "anirudh-hegde (via GitHub)" <gi...@apache.org>.
anirudh-hegde commented on PR #6205:
URL: https://github.com/apache/seatunnel/pull/6205#issuecomment-2019356684

   Hey someone please review my code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

Posted by "anirudh-hegde (via GitHub)" <gi...@apache.org>.
anirudh-hegde commented on code in PR #6205:
URL: https://github.com/apache/seatunnel/pull/6205#discussion_r1451974591


##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java:
##########


Review Comment:
   Please don't merge this as I did not contribute to this file in rim branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

Posted by "anirudh-hegde (via GitHub)" <gi...@apache.org>.
anirudh-hegde commented on PR #6205:
URL: https://github.com/apache/seatunnel/pull/6205#issuecomment-1991545490

   > ![image](https://private-user-images.githubusercontent.com/105560839/312059688-839548e8-51c6-4030-85ed-5fc1d922bf94.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAyNDY5NjcsIm5iZiI6MTcxMDI0NjY2NywicGF0aCI6Ii8xMDU1NjA4MzkvMzEyMDU5Njg4LTgzOTU0OGU4LTUxYzYtNDAzMC04NWVkLTVmYzFkOTIyYmY5NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMzEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDMxMlQxMjMxMDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YWMyYzkxNzYyZjI2OWM5MDI2Mzg2ZmFhNjFjOTBiZWQyZWY5MmJmMTliZDhiZWFjNzVlNDBjMjFhMDdhMzI1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.SurTMaxyoGNbmVPUJEMJj6kzFU7B7AvPzmbR2W3Z9DI) dead links found!!
   
   I fixed the deas links


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #6205:
URL: https://github.com/apache/seatunnel/pull/6205#discussion_r1520818126


##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java:
##########


Review Comment:
   revert this file updates



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #6205:
URL: https://github.com/apache/seatunnel/pull/6205#discussion_r1452068563


##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java:
##########


Review Comment:
   I believe this is a mistake of your git operation.
   ![image](https://github.com/apache/seatunnel/assets/32387433/5af19c0f-770c-48fd-956e-e029aecb683e)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

Posted by "anirudh-hegde (via GitHub)" <gi...@apache.org>.
anirudh-hegde closed pull request #6205: [added] [classes] Added classes to ProtoStuffSerializer file
URL: https://github.com/apache/seatunnel/pull/6205


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #6205:
URL: https://github.com/apache/seatunnel/pull/6205#issuecomment-1891576311

   > I executed mvn spotless:check and mvn spotless:apply I don't know why checks are taking so long.
   
   Maybe it will download some jar in first time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [added] [classes] Added classes to ProtoStuffSerializer file [seatunnel]

Posted by "anirudh-hegde (via GitHub)" <gi...@apache.org>.
anirudh-hegde commented on code in PR #6205:
URL: https://github.com/apache/seatunnel/pull/6205#discussion_r1452259757


##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/constants/JobMode.java:
##########


Review Comment:
   > I believe this is a mistake of your git operation. ![image](https://private-user-images.githubusercontent.com/32387433/296699821-5af19c0f-770c-48fd-956e-e029aecb683e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDUzMTgzMTUsIm5iZiI6MTcwNTMxODAxNSwicGF0aCI6Ii8zMjM4NzQzMy8yOTY2OTk4MjEtNWFmMTljMGYtNzcwYy00OGZkLTk1NmUtZTAyOWFlY2I2ODNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTE1VDExMjY1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThmMTAwZmZiYWZkN2JiMGE0YjRjZTNlNmU3ZGE3ZTExM2U5MmFhMWM3Y2E5MDM4NGYyYjdhMWIzYzQyMDZiMDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ujxGV8JsaaAASmrvq4AXpfZ6VIHwATzfz_rFT3qjNXk)
   
   I want to delete the file commit https://github.com/apache/seatunnel/pull/6205/commits/843e735074226b0c0abb36633bb003642e3b3f97



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org