You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/06/29 12:13:58 UTC
[GitHub] [airflow] potiuk commented on pull request #32248: Fix behaviour of LazyDictWithCache when import fails
potiuk commented on PR #32248:
URL: https://github.com/apache/airflow/pull/32248#issuecomment-1613048125
> tip of the hat to you
Took a bit to figure out. Generally the whole thing with lazy caching there is likely now too complex (and less needed) after some other optimizations has been implemented by @uranusjr and @ashb much later. Those changes ptimized the usage on other layers - for example https://github.com/apache/airflow/pull/24486, https://github.com/apache/airflow/pull/29625, https://github.com/apache/airflow/pull/29946.
So it might be that some of the complexity at the lower layer of caching might be simply not needed any more (those the same lazy cache dict is used for decorators not only for providers, so maybe we still need it)
Maybe one day we can revisit that. For now just fixing it is simplest and least risky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org