You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/06 13:17:01 UTC

[I] fix: distinguish failed message queries from empty results [rocketmq-dashboard]

Aias00 opened a new issue, #1161:
URL: https://github.com/apache/rocketmq-dashboard/issues/1161

   ## Problem
   
   `RocketMQMessageProvider` catches Admin and pull-consumer failures for Key and Topic time-range message queries, then returns an empty list. The API therefore responds with success even when the selected RocketMQ instance is unavailable or rejects the request.
   
   ## Expected behavior
   
   A completed query with no matching messages may return an empty list. A remote query failure must return a structured gateway error so the console can distinguish it from an empty result.
   
   ## Scope
   
   Track 1 / BASE-01 message query correctness. Limit the initial change to Key and Topic time-range query modes; message-id lookup keeps its existing fallback behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] fix: distinguish failed message queries from empty results [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #1161:
URL: https://github.com/apache/rocketmq-dashboard/issues/1161#issuecomment-5205855197

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The issue is valid. `RocketMQMessageProvider` catches Admin and pull-consumer failures during Key and Topic time-range message queries and returns empty lists, making the API respond with success even when the instance is unavailable.
   
   **Root Cause:** Exception handling in message query paths silently converts failures to empty results.
   **Impact:** Users cannot distinguish between "no matching messages" and "query failed" — may miss critical messages during incident investigation.
   **Severity:** Medium — operational reliability concern.
   
   An automated fix proposal can be generated if the community confirms. Reply `/approve` to proceed with PR generation.
   
   ---
   *Automated evaluation by github-manager*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] fix: distinguish failed message queries from empty results [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on issue #1161:
URL: https://github.com/apache/rocketmq-dashboard/issues/1161#issuecomment-5223943432

   Closing as already fixed in the current `rocketmq-studio` baseline by commit d1bb6106 (`fix: distinguish failed message queries`). `RocketMQMessageProviderTest` covers both Key-query and time-range query failures returning structured 502 errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] fix: distinguish failed message queries from empty results [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #1161: fix: distinguish failed message queries from empty results
URL: https://github.com/apache/rocketmq-dashboard/issues/1161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org