You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/19 12:00:32 UTC
[GitHub] [shardingsphere] zjcnb opened a new pull request, #16930: Adjust schemaName to databaseName
zjcnb opened a new pull request, #16930:
URL: https://github.com/apache/shardingsphere/pull/16930
For #14004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #16930: Adjust schemaName to databaseName
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on code in PR #16930:
URL: https://github.com/apache/shardingsphere/pull/16930#discussion_r852988031
##########
shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/resources/conf/config-sharding.yaml:
##########
@@ -120,75 +120,75 @@
#
######################################################################################################
-#databaseName: sharding_db
-#
-#dataSources:
-# ds_0:
-# url: jdbc:mysql://127.0.0.1:3306/demo_ds_0?serverTimezone=UTC&useSSL=false
-# username: root
-# password:
-# connectionTimeoutMilliseconds: 30000
-# idleTimeoutMilliseconds: 60000
-# maxLifetimeMilliseconds: 1800000
-# maxPoolSize: 50
-# minPoolSize: 1
-# ds_1:
-# url: jdbc:mysql://127.0.0.1:3306/demo_ds_1?serverTimezone=UTC&useSSL=false
-# username: root
-# password:
-# connectionTimeoutMilliseconds: 30000
-# idleTimeoutMilliseconds: 60000
-# maxLifetimeMilliseconds: 1800000
-# maxPoolSize: 50
-# minPoolSize: 1
-#
-#rules:
-#- !SHARDING
-# tables:
-# t_order:
-# actualDataNodes: ds_${0..1}.t_order_${0..1}
-# tableStrategy:
-# standard:
-# shardingColumn: order_id
-# shardingAlgorithmName: t_order_inline
-# keyGenerateStrategy:
-# column: order_id
-# keyGeneratorName: snowflake
-# t_order_item:
-# actualDataNodes: ds_${0..1}.t_order_item_${0..1}
-# tableStrategy:
-# standard:
-# shardingColumn: order_id
-# shardingAlgorithmName: t_order_item_inline
-# keyGenerateStrategy:
-# column: order_item_id
-# keyGeneratorName: snowflake
-# bindingTables:
-# - t_order,t_order_item
-# defaultDatabaseStrategy:
-# standard:
-# shardingColumn: user_id
-# shardingAlgorithmName: database_inline
-# defaultTableStrategy:
-# none:
-#
-# shardingAlgorithms:
-# database_inline:
-# type: INLINE
-# props:
-# algorithm-expression: ds_${user_id % 2}
-# t_order_inline:
-# type: INLINE
-# props:
-# algorithm-expression: t_order_${order_id % 2}
-# t_order_item_inline:
-# type: INLINE
-# props:
-# algorithm-expression: t_order_item_${order_id % 2}
-#
-# keyGenerators:
-# snowflake:
-# type: SNOWFLAKE
+databaseName: sharding_db
Review Comment:
why you uncomment these configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #16930: Adjust schemaName to databaseName
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #16930:
URL: https://github.com/apache/shardingsphere/pull/16930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16930: Adjust schemaName to databaseName
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16930:
URL: https://github.com/apache/shardingsphere/pull/16930#issuecomment-1102880994
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16930?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16930](https://codecov.io/gh/apache/shardingsphere/pull/16930?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bb8deb) into [master](https://codecov.io/gh/apache/shardingsphere/commit/21b6b78240094b8bc37f2da776b7ab59bb904c61?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21b6b78) will **increase** coverage by `0.03%`.
> The diff coverage is `95.57%`.
```diff
@@ Coverage Diff @@
## master #16930 +/- ##
============================================
+ Coverage 60.19% 60.23% +0.03%
Complexity 2128 2128
============================================
Files 3441 3439 -2
Lines 51739 51700 -39
Branches 8845 8844 -1
============================================
- Hits 31146 31139 -7
+ Misses 17971 17938 -33
- Partials 2622 2623 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16930?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ateShardingBroadcastTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlU2hhcmRpbmdCcm9hZGNhc3RUYWJsZVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...tion/resource/RequiredResourceMissedException.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kaXN0c3FsL2V4Y2VwdGlvbi9yZXNvdXJjZS9SZXF1aXJlZFJlc291cmNlTWlzc2VkRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...le/DropDefaultSingleTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL3J1bGUvRHJvcERlZmF1bHRTaW5nbGVUYWJsZVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `75.00% <66.66%> (ø)` | |
| [...er/update/DropShadowAlgorithmStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYWRvdy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Ryb3BTaGFkb3dBbGdvcml0aG1TdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `65.62% <71.42%> (ø)` | |
| [.../CreateDefaultSingleTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL3J1bGUvQ3JlYXRlRGVmYXVsdFNpbmdsZVRhYmxlUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `73.68% <80.00%> (ø)` | |
| [...terDatabaseDiscoveryHeartbeatStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQWx0ZXJEYXRhYmFzZURpc2NvdmVyeUhlYXJ0YmVhdFN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `70.83% <85.71%> (ø)` | |
| [...te/AlterDatabaseDiscoveryTypeStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQWx0ZXJEYXRhYmFzZURpc2NvdmVyeVR5cGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `87.09% <85.71%> (ø)` | |
| [.../AlterDefaultShardingStrategyStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQWx0ZXJEZWZhdWx0U2hhcmRpbmdTdHJhdGVneVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `90.56% <85.71%> (ø)` | |
| [...lterShardingBindingTableRulesStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQWx0ZXJTaGFyZGluZ0JpbmRpbmdUYWJsZVJ1bGVzU3RhdGVtZW50VXBkYXRlci5qYXZh) | `45.94% <85.71%> (ø)` | |
| [...reateShardingBindingTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlU2hhcmRpbmdCaW5kaW5nVGFibGVSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `52.94% <85.71%> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/shardingsphere/pull/16930/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16930?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16930?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21b6b78...0bb8deb](https://codecov.io/gh/apache/shardingsphere/pull/16930?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on a diff in pull request #16930: Adjust schemaName to databaseName
Posted by GitBox <gi...@apache.org>.
zjcnb commented on code in PR #16930:
URL: https://github.com/apache/shardingsphere/pull/16930#discussion_r852992967
##########
shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/resources/conf/config-sharding.yaml:
##########
@@ -120,75 +120,75 @@
#
######################################################################################################
-#databaseName: sharding_db
-#
-#dataSources:
-# ds_0:
-# url: jdbc:mysql://127.0.0.1:3306/demo_ds_0?serverTimezone=UTC&useSSL=false
-# username: root
-# password:
-# connectionTimeoutMilliseconds: 30000
-# idleTimeoutMilliseconds: 60000
-# maxLifetimeMilliseconds: 1800000
-# maxPoolSize: 50
-# minPoolSize: 1
-# ds_1:
-# url: jdbc:mysql://127.0.0.1:3306/demo_ds_1?serverTimezone=UTC&useSSL=false
-# username: root
-# password:
-# connectionTimeoutMilliseconds: 30000
-# idleTimeoutMilliseconds: 60000
-# maxLifetimeMilliseconds: 1800000
-# maxPoolSize: 50
-# minPoolSize: 1
-#
-#rules:
-#- !SHARDING
-# tables:
-# t_order:
-# actualDataNodes: ds_${0..1}.t_order_${0..1}
-# tableStrategy:
-# standard:
-# shardingColumn: order_id
-# shardingAlgorithmName: t_order_inline
-# keyGenerateStrategy:
-# column: order_id
-# keyGeneratorName: snowflake
-# t_order_item:
-# actualDataNodes: ds_${0..1}.t_order_item_${0..1}
-# tableStrategy:
-# standard:
-# shardingColumn: order_id
-# shardingAlgorithmName: t_order_item_inline
-# keyGenerateStrategy:
-# column: order_item_id
-# keyGeneratorName: snowflake
-# bindingTables:
-# - t_order,t_order_item
-# defaultDatabaseStrategy:
-# standard:
-# shardingColumn: user_id
-# shardingAlgorithmName: database_inline
-# defaultTableStrategy:
-# none:
-#
-# shardingAlgorithms:
-# database_inline:
-# type: INLINE
-# props:
-# algorithm-expression: ds_${user_id % 2}
-# t_order_inline:
-# type: INLINE
-# props:
-# algorithm-expression: t_order_${order_id % 2}
-# t_order_item_inline:
-# type: INLINE
-# props:
-# algorithm-expression: t_order_item_${order_id % 2}
-#
-# keyGenerators:
-# snowflake:
-# type: SNOWFLAKE
+databaseName: sharding_db
Review Comment:
Sorry, this should not be submitted. I will recover it. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org