You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lburgazzoli (via GitHub)" <gi...@apache.org> on 2024/05/07 21:25:52 UTC
[PR] chore: update golagci-lint to v1.158.0 [camel-k]
lburgazzoli opened a new pull request, #5471:
URL: https://github.com/apache/camel-k/pull/5471
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update golagci-lint to v1.158.0 [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli merged PR #5471:
URL: https://github.com/apache/camel-k/pull/5471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update golagci-lint to v1.158.0 [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #5471:
URL: https://github.com/apache/camel-k/pull/5471#discussion_r1593534682
##########
.golangci.yml:
##########
@@ -73,3 +74,7 @@ linters:
- whitespace
- wrapcheck
- wsl
+ - execinquery
+ # TODO: too much work at this stage, but they should be re-enabled
Review Comment:
Just out of curiosity. What this comment exactly mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update golagci-lint to v1.158.0 [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #5471:
URL: https://github.com/apache/camel-k/pull/5471#issuecomment-2100098688
@squakez do we have already a PR/commit for the security finding ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update golagci-lint to v1.158.0 [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on code in PR #5471:
URL: https://github.com/apache/camel-k/pull/5471#discussion_r1593554209
##########
.golangci.yml:
##########
@@ -73,3 +74,7 @@ linters:
- whitespace
- wrapcheck
- wsl
+ - execinquery
+ # TODO: too much work at this stage, but they should be re-enabled
Review Comment:
I have improved it a little bit the description
TL;DR; fixing the warning would have required to change a lot of files so I'll open some new issues to track the tasks once this gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: update golagci-lint to v1.158.0 [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5471:
URL: https://github.com/apache/camel-k/pull/5471#issuecomment-2100110890
> @squakez do we have already a PR/commit for the security finding ?
No, it should eventually fixed automatically when the golang action will move to `1.21.10`. Feel free to merge if that one is the only check failure you got.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org