Re: [PR] fix: localization of humanize naturaltime [superset]

["Quatters (via GitHub)" <gi...@apache.org>]

Quatters commented on code in PR #33189:
URL: https://github.com/apache/superset/pull/33189#discussion_r2185317152


##########
superset/utils/core.py:
##########
@@ -1831,3 +1833,10 @@ def get_user_agent(database: Database, source: QuerySource | None) -> str:
         return user_agent_func(database, source)
 
     return DEFAULT_USER_AGENT
+
+
+def activate_humanize_locale() -> str:
+    locale = session.get("locale", "en")

Review Comment:
   nit: maybe you should use `get_locale` (`from flask_babel import get_locale`)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org