[GitHub] [flink] wanglijie95 commented on a diff in pull request #20079: [FLINK-28143][runtime] Introduce BlocklistHandler

[GitBox <gi...@apache.org>]

wanglijie95 commented on code in PR #20079:
URL: https://github.com/apache/flink/pull/20079#discussion_r911834985


##########
flink-runtime/src/main/java/org/apache/flink/runtime/blocklist/BlockedNode.java:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.blocklist;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+import static org.apache.flink.util.Preconditions.checkState;
+
+/** This class represents a blocked node record. */
+public class BlockedNode implements Serializable {
+
+    private final String nodeId;
+
+    private final Set<String> causes = new HashSet<>();
+
+    private final long endTimestamp;
+
+    BlockedNode(String nodeId, String cause, long endTimestamp) {
+        this(nodeId, Collections.singleton(cause), endTimestamp);
+    }
+
+    BlockedNode(String nodeId, Collection<String> causes, long endTimestamp) {
+        this.nodeId = checkNotNull(nodeId);
+        this.causes.addAll(checkNotNull(causes));
+        this.endTimestamp = endTimestamp;
+    }
+
+    public String getNodeId() {
+        return nodeId;
+    }
+
+    public Collection<String> getCauses() {
+        return causes;
+    }
+
+    public long getEndTimestamp() {
+        return endTimestamp;
+    }
+
+    public static BlockedNode merge(BlockedNode node, BlockedNode other) {
+        checkNotNull(node);
+        checkNotNull(other);
+        checkState(node.nodeId.equals(other.nodeId));
+
+        Set<String> mergedCauses = new HashSet<>();
+        mergedCauses.addAll(node.causes);
+        mergedCauses.addAll(other.causes);
+
+        long mergedEndTimestamp = Math.max(node.endTimestamp, other.endTimestamp);

Review Comment:
   Make sense. Assume the existing one is A, new one is B, A.endTimestamp == B.endTimestamp and A.cause != B.cause. Then I think the merged one should be [B.endTimestamp, B.cause] . WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org