You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by al...@apache.org on 2015/12/09 14:06:35 UTC
svn commit: r1718848 -
/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java
Author: alexparvulescu
Date: Wed Dec 9 13:06:35 2015
New Revision: 1718848
URL: http://svn.apache.org/viewvc?rev=1718848&view=rev
Log:
OAK-3756 NodeStateUtils wrong indentation for toString method
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java?rev=1718848&r1=1718847&r2=1718848&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java Wed Dec 9 13:06:35 2015
@@ -100,7 +100,7 @@ public final class NodeStateUtils {
private static String toString(NodeState ns, int level, String prepend,
String name) {
StringBuilder node = new StringBuilder();
- node.append(prepend).append(name);
+ node.append(multiplier(prepend, level)).append(name);
StringBuilder props = new StringBuilder();
boolean first = true;
@@ -120,10 +120,18 @@ public final class NodeStateUtils {
}
for (ChildNodeEntry c : ns.getChildNodeEntries()) {
node.append(IOUtils.LINE_SEPARATOR);
- node.append(toString(c.getNodeState(), level++, prepend + prepend,
+ node.append(toString(c.getNodeState(), level + 1, prepend,
c.getName()));
}
return node.toString();
}
+ private static String multiplier(String in, int times) {
+ StringBuilder sb = new StringBuilder();
+ for (int i = 0; i < times; i++) {
+ sb.append(in);
+ }
+ return sb.toString();
+ }
+
}
Re: svn commit: r1718848 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java
Posted by Alex Parvulescu <al...@gmail.com>.
ah, good one! did not know about this, I'll replace the code
On Wed, Dec 9, 2015 at 2:20 PM, Chetan Mehrotra <ch...@gmail.com>
wrote:
> On Wed, Dec 9, 2015 at 6:36 PM, <al...@apache.org> wrote:
> > + private static String multiplier(String in, int times) {
> > + StringBuilder sb = new StringBuilder();
> > + for (int i = 0; i < times; i++) {
> > + sb.append(in);
> > + }
> > + return sb.toString();
> > + }
> > +
>
> May be use com.google.common.base.Strings#repeat?
>
> Chetan Mehrotra
>
Re: svn commit: r1718848 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java
Posted by Chetan Mehrotra <ch...@gmail.com>.
On Wed, Dec 9, 2015 at 6:36 PM, <al...@apache.org> wrote:
> + private static String multiplier(String in, int times) {
> + StringBuilder sb = new StringBuilder();
> + for (int i = 0; i < times; i++) {
> + sb.append(in);
> + }
> + return sb.toString();
> + }
> +
May be use com.google.common.base.Strings#repeat?
Chetan Mehrotra