You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Fabian Bauschulte (JIRA)" <ji...@codehaus.org> on 2006/05/20 15:20:40 UTC
[jira] Created: (MCHECKSTYLE-45) It should be possible to configure
checkstyle:check to fail on "warnings".
It should be possible to configure checkstyle:check to fail on "warnings".
--------------------------------------------------------------------------
Key: MCHECKSTYLE-45
URL: http://jira.codehaus.org/browse/MCHECKSTYLE-45
Project: Maven 2.x Checkstyle Plugin
Type: New Feature
Versions: 2.1
Reporter: Fabian Bauschulte
As mentioned in MCHECKSTYLE-38 it should be possible to configure that "checkstyle:check" fails on warnings or not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Kommentiert: (MCHECKSTYLE-45) It should be possible to
configure checkstyle:check to fail on "warnings".
Posted by "Fabian Bauschulte (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-45?page=comments#action_67209 ]
Fabian Bauschulte commented on MCHECKSTYLE-45:
----------------------------------------------
I want to make sure that no version with checkstyle warnings (for example missing javadoc comments) is deployed. I am using the checkstyle eclipse plugin. While developing it can sometimes very annoying to change all your rules to "error" - for example if you only want to try something out.
In this case it would be very helpful to have this option. The default would be to fail "on error" - the check would only fail change the parameter.
> It should be possible to configure checkstyle:check to fail on "warnings".
> --------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-45
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-45
> Project: Maven 2.x Checkstyle Plugin
> Type: New Feature
> Versions: 2.1
> Reporter: Fabian Bauschulte
> Attachments: MCHECKSTYLE-45-maven-checkstyle-plugin.patch
>
>
> As mentioned in MCHECKSTYLE-38 it should be possible to configure that "checkstyle:check" fails on warnings or not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-45) It should be possible to configure
checkstyle:check to fail on "warnings".
Posted by "Fabian Bauschulte (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-45?page=all ]
Fabian Bauschulte updated MCHECKSTYLE-45:
-----------------------------------------
Attachment: MCHECKSTYLE-45-maven-checkstyle-plugin.patch
> It should be possible to configure checkstyle:check to fail on "warnings".
> --------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-45
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-45
> Project: Maven 2.x Checkstyle Plugin
> Type: New Feature
> Versions: 2.1
> Reporter: Fabian Bauschulte
> Attachments: MCHECKSTYLE-45-maven-checkstyle-plugin.patch
>
>
> As mentioned in MCHECKSTYLE-38 it should be possible to configure that "checkstyle:check" fails on warnings or not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-45) It should be possible to
configure checkstyle:check to fail on "warnings".
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-45?page=comments#action_67183 ]
Carlos Sanchez commented on MCHECKSTYLE-45:
-------------------------------------------
I don't think this should be changed. A warning is by definition just that, a warning.
> It should be possible to configure checkstyle:check to fail on "warnings".
> --------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-45
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-45
> Project: Maven 2.x Checkstyle Plugin
> Type: New Feature
> Versions: 2.1
> Reporter: Fabian Bauschulte
> Attachments: MCHECKSTYLE-45-maven-checkstyle-plugin.patch
>
>
> As mentioned in MCHECKSTYLE-38 it should be possible to configure that "checkstyle:check" fails on warnings or not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-45) It should be possible to
configure checkstyle:check to fail on "warnings".
Posted by "Mark Roder (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-45?page=comments#action_79023 ]
Mark Roder commented on MCHECKSTYLE-45:
---------------------------------------
I have a similar problem/need to Fabian and Jacob.
The supplied patch will support what I need to do for my projects and allow different levels of checkstyle alerts to fail the build.
> It should be possible to configure checkstyle:check to fail on "warnings".
> --------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-45
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-45
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Affects Versions: 2.1
> Reporter: Fabian Bauschulte
> Attachments: MCHECKSTYLE-45-maven-checkstyle-plugin.patch
>
>
> As mentioned in MCHECKSTYLE-38 it should be possible to configure that "checkstyle:check" fails on warnings or not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHECKSTYLE-45) It should be possible to configure
checkstyle:check to fail on "warnings".
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MCHECKSTYLE-45.
--------------------------------------
Assignee: Dennis Lundberg
Resolution: Fixed
Fix Version/s: 2.2
Patch applied with modifications in r617999. Thanks!
A new 2.2-SNAPSHOT with this feature has been uploaded to the snapshot repository.
> It should be possible to configure checkstyle:check to fail on "warnings".
> --------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-45
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-45
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Affects Versions: 2.1
> Reporter: Fabian Bauschulte
> Assignee: Dennis Lundberg
> Fix For: 2.2
>
> Attachments: MCHECKSTYLE-45-maven-checkstyle-plugin.patch
>
>
> As mentioned in MCHECKSTYLE-38 it should be possible to configure that "checkstyle:check" fails on warnings or not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-45) It should be possible to
configure checkstyle:check to fail on "warnings".
Posted by "Jacob Robertson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-45?page=comments#action_75916 ]
Jacob Robertson commented on MCHECKSTYLE-45:
--------------------------------------------
Let me describe my situation.
First off, we use one common checkstyle.xml definition hosted on an internal http server. This same checkstyle.xml is consumed by both the eclipse-cs plugin (as we develop in eclipse) and by maven both when continuum kicks it off and when we run it locally.
However, we were very unhappy with using "error" on any of our checks, because in the IDE it was showing up so as to mask whether it was a true build error or just a checkstyle error. We fought with that for a while, and in the end just changed our checkstyle.xml to declare globally that all checks were just warnings.
But now we would also like to explore the possibility of having maven "break the build" when the checkstyle *warnings* show up. Here is the rationale: while developing in eclipse, we want things to show up as warnings to make our IDE experience livable. However, once we go to check something in, we know that all those warnings must be cleared up or we'll break the build. This way, we get the best of both worlds.
All I'm trying to do is demonstrate a practical, real-world scenario under which this feature would be useful.
> It should be possible to configure checkstyle:check to fail on "warnings".
> --------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-45
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-45
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: New Feature
> Affects Versions: 2.1
> Reporter: Fabian Bauschulte
> Attachments: MCHECKSTYLE-45-maven-checkstyle-plugin.patch
>
>
> As mentioned in MCHECKSTYLE-38 it should be possible to configure that "checkstyle:check" fails on warnings or not.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira