You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jay SenSharma <jo...@gmail.com> on 2017/01/03 08:41:32 UTC
Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
Bugs: AMBARI-19337
https://issues.apache.org/jira/browse/AMBARI-19337
Repository: ambari
Description
-------
YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
Diff: https://reviews.apache.org/r/55129/diff/
Testing
-------
Existing testcases does not directly address this. So test not performed.
Thanks,
Jay SenSharma
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review160384
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Jan. 3, 2017, 8:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 8:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Jan. 17, 2017, 8:08 p.m., Nate Cole wrote:
> > Ping.
I just committed it. Jay can you close it.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review161930
-----------------------------------------------------------
On Jan. 3, 2017, 8:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 8:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Jay SenSharma <jo...@gmail.com>.
> On Jan. 17, 2017, 8:08 p.m., Nate Cole wrote:
> > Ping.
>
> Sumit Mohanty wrote:
> I just committed it. Jay can you close it.
Sumit, i see 'Alejandro' has some queries related to the property change to existing clusters. Once that discussion is over then we can close this review.
- Jay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review161930
-----------------------------------------------------------
On Jan. 3, 2017, 8:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 8:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review161930
-----------------------------------------------------------
Ping.
- Nate Cole
On Jan. 3, 2017, 3:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 3:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Jan. 17, 2017, 3:45 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json, line 26
> > <https://reviews.apache.org/r/55129/diff/1/?file=1595429#file1595429line26>
> >
> > This is essentially changing the config name.
> > What should happen to existing clusters already Kerberized?
> > Should the propery be renamed?
>
> Jay SenSharma wrote:
> If the property name itself is wrong in an existing cluster then i guess it might not be working as expected earlier as well, because the YARN will ignore those properties which are incorrect (non existing). So i think for the existing clusters it needs to be corrected.
>
> Please correct me if above statement is incorrect.
>
> Sumit Mohanty wrote:
> Lets open a separate JIRA to fix the properties during HDP upgrade. Chances are high that these clusters are fixed by the users as without the fixes they will see access issued.
I had figured that if the existing incorrect spellings were present, YARN would ignore them.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review161941
-----------------------------------------------------------
On Jan. 3, 2017, 3:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 3:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Jan. 17, 2017, 8:45 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json, line 26
> > <https://reviews.apache.org/r/55129/diff/1/?file=1595429#file1595429line26>
> >
> > This is essentially changing the config name.
> > What should happen to existing clusters already Kerberized?
> > Should the propery be renamed?
>
> Jay SenSharma wrote:
> If the property name itself is wrong in an existing cluster then i guess it might not be working as expected earlier as well, because the YARN will ignore those properties which are incorrect (non existing). So i think for the existing clusters it needs to be corrected.
>
> Please correct me if above statement is incorrect.
Lets open a separate JIRA to fix the properties during HDP upgrade. Chances are high that these clusters are fixed by the users as without the fixes they will see access issued.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review161941
-----------------------------------------------------------
On Jan. 3, 2017, 8:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 8:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Jay SenSharma <jo...@gmail.com>.
> On Jan. 17, 2017, 8:45 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json, line 26
> > <https://reviews.apache.org/r/55129/diff/1/?file=1595429#file1595429line26>
> >
> > This is essentially changing the config name.
> > What should happen to existing clusters already Kerberized?
> > Should the propery be renamed?
If the property name itself is wrong in an existing cluster then i guess it might not be working as expected earlier as well, because the YARN will ignore those properties which are incorrect (non existing). So i think for the existing clusters it needs to be corrected.
Please correct me if above statement is incorrect.
- Jay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review161941
-----------------------------------------------------------
On Jan. 3, 2017, 8:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 8:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review161941
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json (line 26)
<https://reviews.apache.org/r/55129/#comment233219>
This is essentially changing the config name.
What should happen to existing clusters already Kerberized?
Should the propery be renamed?
- Alejandro Fernandez
On Jan. 3, 2017, 8:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 8:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review160381
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 3, 2017, 3:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 3:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review160506
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 3, 2017, 3:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 3:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling
mistakes in YARN proxyuser properties in many places.
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55129/#review161280
-----------------------------------------------------------
Ping. What's the status of this review?
- Nate Cole
On Jan. 3, 2017, 3:41 a.m., Jay SenSharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55129/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 3:41 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-19337
> https://issues.apache.org/jira/browse/AMBARI-19337
>
>
> Repository: ambari
>
>
> Description
> -------
>
> YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9
> ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5
> ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd
> ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24
> ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8
>
> Diff: https://reviews.apache.org/r/55129/diff/
>
>
> Testing
> -------
>
> Existing testcases does not directly address this. So test not performed.
>
>
> Thanks,
>
> Jay SenSharma
>
>