You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/23 08:53:44 UTC
[GitHub] [kafka] socutes opened a new pull request #11530: MINOR:Delete unnecessary comment information
socutes opened a new pull request #11530:
URL: https://github.com/apache/kafka/pull/11530
Delete unnecessary comment information：SnapshotWriter.createWithHeader()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] socutes commented on pull request #11530: MINOR:Delete unnecessary comment information
Posted by GitBox <gi...@apache.org>.
socutes commented on pull request #11530:
URL: https://github.com/apache/kafka/pull/11530#issuecomment-976295157
@showuon PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11530: MINOR:Delete unnecessary comment information
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11530:
URL: https://github.com/apache/kafka/pull/11530#discussion_r755787840
##########
File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java
##########
@@ -113,10 +113,8 @@ private void finalizeSnapshotWithFooter() {
* Create an instance of this class and initialize
* the underlying snapshot with {@link SnapshotHeaderRecord}
*
- * @param snapshot a lambda to create the low level snapshot writer
* @param maxBatchSize the maximum size in byte for a batch
* @param memoryPool the memory pool for buffer allocation
- * @param time the clock implementation
Review comment:
You're right! I just checked the parameter, and make sure there's no such parameter called `time`. But, yes, it's put the wrong name. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] socutes commented on pull request #11530: MINOR:Update code comment information
Posted by GitBox <gi...@apache.org>.
socutes commented on pull request #11530:
URL: https://github.com/apache/kafka/pull/11530#issuecomment-979689692
@showuon @dajac Thanks~. fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11530: MINOR:Delete unnecessary comment information
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11530:
URL: https://github.com/apache/kafka/pull/11530#discussion_r755787945
##########
File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java
##########
@@ -113,10 +113,8 @@ private void finalizeSnapshotWithFooter() {
* Create an instance of this class and initialize
* the underlying snapshot with {@link SnapshotHeaderRecord}
*
- * @param snapshot a lambda to create the low level snapshot writer
Review comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11530: MINOR:Delete unnecessary comment information
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11530:
URL: https://github.com/apache/kafka/pull/11530#issuecomment-977630216
@socutes , sorry that I didn't catch the issue that @dajac mentioned. Please update the PR. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #11530: MINOR:Delete unnecessary comment information
Posted by GitBox <gi...@apache.org>.
dajac commented on a change in pull request #11530:
URL: https://github.com/apache/kafka/pull/11530#discussion_r755784474
##########
File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java
##########
@@ -113,10 +113,8 @@ private void finalizeSnapshotWithFooter() {
* Create an instance of this class and initialize
* the underlying snapshot with {@link SnapshotHeaderRecord}
*
- * @param snapshot a lambda to create the low level snapshot writer
Review comment:
Should this be `supplier` instead of `snapshot`?
##########
File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java
##########
@@ -113,10 +113,8 @@ private void finalizeSnapshotWithFooter() {
* Create an instance of this class and initialize
* the underlying snapshot with {@link SnapshotHeaderRecord}
*
- * @param snapshot a lambda to create the low level snapshot writer
* @param maxBatchSize the maximum size in byte for a batch
* @param memoryPool the memory pool for buffer allocation
- * @param time the clock implementation
Review comment:
Should this be `snapshotTime` instead of `time`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #11530: MINOR: Update javadoc of `SnapshotWriter.createWithHeader`
Posted by GitBox <gi...@apache.org>.
dajac merged pull request #11530:
URL: https://github.com/apache/kafka/pull/11530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org