You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2015/11/23 11:18:44 UTC
[GitHub] incubator-brooklyn pull request: Fix BrooklynProperties.Factory.Bu...
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1055
Fix BrooklynProperties.Factory.Builder.builderEmpty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn empty_brooklyn_properties
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1055.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1055
----
commit 1ab7c4f042f6ef747862c01b44e8cfaa65824490
Author: Valentin Aitken <va...@cloudsoftcorp.com>
Date: 2015-11-23T10:17:10Z
Fix BrooklynProperties.Factory.Builder.builderEmpty
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix BrooklynProperties.Factory.Bu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1055
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix BrooklynProperties.Factory.Bu...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1055#issuecomment-158908747
Good spot. Will wait for Jenkins. You could also delete the comment on line ~102 that says "TODO it's always called with true here, perhaps we don't need the argument?"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---