You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/02/09 01:33:00 UTC
[jira] [Commented] (GEODE-6355) Synchronization issues in
InternalDistributedSystem function stats
[ https://issues.apache.org/jira/browse/GEODE-6355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764021#comment-16764021 ]
ASF subversion and git services commented on GEODE-6355:
--------------------------------------------------------
Commit 127cf7b1d2e8a27103ff99671e80949097863aef in geode's branch refs/heads/develop from Galen O'Sullivan
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=127cf7b ]
GEODE-6355: Fix Synchronization of Function stats in IDS. (#3158)
* Don't use double-checked locking.
* Use computeIfAbsent instead of locking on the object.
Cleanup:
* Rename listeners to disconnectListeners.
* Remove dead code
* generify collections
* Change some loops to foreach
* Make a ThreadLocal use withInitial
* Make methods and fields private
> Synchronization issues in InternalDistributedSystem function stats
> ------------------------------------------------------------------
>
> Key: GEODE-6355
> URL: https://issues.apache.org/jira/browse/GEODE-6355
> Project: Geode
> Issue Type: Bug
> Reporter: Galen O'Sullivan
> Assignee: Galen O'Sullivan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This uses double-checked locking, which is a broken pattern, and we should use computeIfAbsent. In getFunctionStats and getFunctionStats.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)