You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@freestoneinfotech.com> on 2017/05/04 06:21:25 UTC

Review Request 58982: RANGER-1557 : Add Nifi as default in supported component list

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58982/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1557
    https://issues.apache.org/jira/browse/RANGER-1557


Repository: ranger


Description
-------

**Problem Statement :** Currently NiFi service definition is not added in Ranger UI as Nifi Service def is not created by default at the time of Ranger Start. It is happening because Nifi service-def name is not added in default supported service list.

**Proposed Solution :** Add Nifi service also in default supported service-def list added in    DEFAULT_BOOTSTRAP_SERVICEDEF_LIST. Currently default supported components are : tag,hdfs,hbase,hive,kms,knox,storm,yarn,kafka,solr,atlas


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java bbb4197 


Diff: https://reviews.apache.org/r/58982/diff/1/


Testing
-------

**Steps Performed with patch:**
1. Installed and Started Ranger admin.
2. Logged into Ranger Admin and dashboard page appeared.

** Expected Behaviour: **
NiFi service should also be listed in Ranger Dashboard page (Resource based policy page)

**Actual Behaviour**
NiFi service was listed in Ranger Dashboard page (Resource based policy page)

=> Was able to create Nifi service successfully.

Note : Upgraded Ranger from 0.6 to 1.0.0 version(build with patch) and after login Ranger admin dashboard page was showing NiFi service also.


Thanks,

Pradeep Agrawal


Re: Review Request 58982: RANGER-1557 : Add Nifi as default in supported component list

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58982/#review173926
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On May 4, 2017, 6:21 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58982/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 6:21 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1557
>     https://issues.apache.org/jira/browse/RANGER-1557
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement :** Currently NiFi service definition is not added in Ranger UI as Nifi Service def is not created by default at the time of Ranger Start. It is happening because Nifi service-def name is not added in default supported service list.
> 
> **Proposed Solution :** Add Nifi service also in default supported service-def list added in    DEFAULT_BOOTSTRAP_SERVICEDEF_LIST. Currently default supported components are : tag,hdfs,hbase,hive,kms,knox,storm,yarn,kafka,solr,atlas
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java bbb4197 
> 
> 
> Diff: https://reviews.apache.org/r/58982/diff/1/
> 
> 
> Testing
> -------
> 
> **Steps Performed with patch:**
> 1. Installed and Started Ranger admin.
> 2. Logged into Ranger Admin and dashboard page appeared.
> 
> ** Expected Behaviour: **
> NiFi service should also be listed in Ranger Dashboard page (Resource based policy page)
> 
> **Actual Behaviour**
> NiFi service was listed in Ranger Dashboard page (Resource based policy page)
> 
> => Was able to create Nifi service successfully.
> 
> Note : Upgraded Ranger from 0.6 to 1.0.0 version(build with patch) and after login Ranger admin dashboard page was showing NiFi service also.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>


Re: Review Request 58982: RANGER-1557 : Add Nifi as default in supported component list

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58982/#review173956
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On May 4, 2017, 6:21 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58982/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 6:21 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1557
>     https://issues.apache.org/jira/browse/RANGER-1557
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement :** Currently NiFi service definition is not added in Ranger UI as Nifi Service def is not created by default at the time of Ranger Start. It is happening because Nifi service-def name is not added in default supported service list.
> 
> **Proposed Solution :** Add Nifi service also in default supported service-def list added in    DEFAULT_BOOTSTRAP_SERVICEDEF_LIST. Currently default supported components are : tag,hdfs,hbase,hive,kms,knox,storm,yarn,kafka,solr,atlas
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java bbb4197 
> 
> 
> Diff: https://reviews.apache.org/r/58982/diff/1/
> 
> 
> Testing
> -------
> 
> **Steps Performed with patch:**
> 1. Installed and Started Ranger admin.
> 2. Logged into Ranger Admin and dashboard page appeared.
> 
> ** Expected Behaviour: **
> NiFi service should also be listed in Ranger Dashboard page (Resource based policy page)
> 
> **Actual Behaviour**
> NiFi service was listed in Ranger Dashboard page (Resource based policy page)
> 
> => Was able to create Nifi service successfully.
> 
> Note : Upgraded Ranger from 0.6 to 1.0.0 version(build with patch) and after login Ranger admin dashboard page was showing NiFi service also.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>