You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/10/26 02:27:18 UTC

[kudu-CR] [rpc] add kudu namespace to DnsResolver in generated code 

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17968


Change subject: [rpc] add kudu namespace to DnsResolver in generated code
......................................................................

[rpc] add kudu namespace to DnsResolver in generated code

When building service proxies in non-Kudu projects like Impala, the lack
of the namespace could result in a build failure.

Change-Id: Ia9a8c8a95256192267c2de7e61d7489f7af6e282
---
M src/kudu/rpc/protoc-gen-krpc.cc
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/17968/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9a8c8a95256192267c2de7e61d7489f7af6e282
Gerrit-Change-Number: 17968
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] [rpc] add kudu namespace to DnsResolver in generated code

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17968 )

Change subject: [rpc] add kudu namespace to DnsResolver in generated code
......................................................................


Patch Set 1: Verified+1 Code-Review+2

unrelated test failure:
  * StopTablets/StopTabletITest.TestShutdownWhileWriting/0


-- 
To view, visit http://gerrit.cloudera.org:8080/17968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a8c8a95256192267c2de7e61d7489f7af6e282
Gerrit-Change-Number: 17968
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 26 Oct 2021 04:50:34 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] add kudu namespace to DnsResolver in generated code

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17968 )

Change subject: [rpc] add kudu namespace to DnsResolver in generated code
......................................................................

[rpc] add kudu namespace to DnsResolver in generated code

When building service proxies in non-Kudu projects like Impala, the lack
of the namespace could result in a build failure.

Change-Id: Ia9a8c8a95256192267c2de7e61d7489f7af6e282
Reviewed-on: http://gerrit.cloudera.org:8080/17968
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/rpc/protoc-gen-krpc.cc
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9a8c8a95256192267c2de7e61d7489f7af6e282
Gerrit-Change-Number: 17968
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [rpc] add kudu namespace to DnsResolver in generated code

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [rpc] add kudu namespace to DnsResolver in generated code
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/17968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia9a8c8a95256192267c2de7e61d7489f7af6e282
Gerrit-Change-Number: 17968
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)