You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2026/05/06 09:15:38 UTC
Re: [PR] [Improvement](unlock)optimize the place of unlock which deadlock occurs when database tables are frequently created or deleted [doris]
morrySnow commented on code in PR #62391:
URL: https://github.com/apache/doris/pull/62391#discussion_r3194270180
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommand.java:
##########
@@ -311,15 +309,15 @@ public AbstractInsertExecutor initPlan(ConnectContext ctx, StmtExecutor stmtExec
buildResult.physicalSink
);
}
- newestTargetTableIf.readUnlock();
} catch (Throwable e) {
- newestTargetTableIf.readUnlock();
// the abortTxn in onFail need to acquire table write lock
if (insertExecutor != null) {
insertExecutor.onFail(e);
}
Throwables.throwIfInstanceOf(e, RuntimeException.class);
throw new IllegalStateException(e.getMessage(), e);
+ } finally {
Review Comment:
@LuGuangming please handle this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org