You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/17 14:53:38 UTC

[GitHub] [incubator-superset] Steejay commented on pull request #10355: feat: SIP-34 explore save modal

Steejay commented on pull request #10355:
URL: https://github.com/apache/incubator-superset/pull/10355#issuecomment-660151394


   @mistercrunch see north star design for _add  chart to new dashboard_
   
   For the After image: The text field under radio buttons would benefit by adding a title so that its clear what the field is for. See SIP-34 screenshot you posted.
   
   <img width="1036" alt="Screen Shot 2020-07-17 at 7 50 44 AM" src="https://user-images.githubusercontent.com/60786102/87799581-40bf7380-c802-11ea-868a-2fcc5e221571.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org