You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/31 10:23:38 UTC
[GitHub] [spark] panbingkun opened a new pull request, #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
panbingkun opened a new pull request, #39326:
URL: https://github.com/apache/spark/pull/39326
### What changes were proposed in this pull request?
The pr aims to upgrade commons-compress from 1.21 to 1.22
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
Posted by GitBox <gi...@apache.org>.
panbingkun commented on PR #39326:
URL: https://github.com/apache/spark/pull/39326#issuecomment-1369460704
I will investigate root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #39326:
URL: https://github.com/apache/spark/pull/39326#discussion_r1059649801
##########
core/pom.xml:
##########
@@ -181,6 +181,10 @@
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-compress</artifactId>
+ </dependency>
Review Comment:
Use `CountingOutputStream` class, so direct dependency should be added
https://github.com/apache/spark/blob/5300028a6fcab2ef118b4d96b2a4186542c030d5/core/src/main/scala/org/apache/spark/deploy/history/EventLogFileWriters.scala#L23-L24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #39326:
URL: https://github.com/apache/spark/pull/39326#issuecomment-1369184722
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #39326:
URL: https://github.com/apache/spark/pull/39326#discussion_r1059648827
##########
core/pom.xml:
##########
@@ -181,6 +181,10 @@
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-compress</artifactId>
+ </dependency>
Review Comment:
<img width="928" alt="image" src="https://user-images.githubusercontent.com/15246973/210139366-9ea00e18-8c93-446a-b98f-8f0162887abf.png">
https://github.com/panbingkun/spark/actions/runs/3811706860/jobs/6485303553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #39326:
URL: https://github.com/apache/spark/pull/39326#discussion_r1060327978
##########
core/pom.xml:
##########
@@ -181,6 +181,10 @@
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-compress</artifactId>
+ </dependency>
Review Comment:
I will investigate root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39326:
URL: https://github.com/apache/spark/pull/39326#discussion_r1059675789
##########
core/pom.xml:
##########
@@ -181,6 +181,10 @@
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-compress</artifactId>
+ </dependency>
Review Comment:
Do you know why this is required by 1.22 only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #39326:
URL: https://github.com/apache/spark/pull/39326#issuecomment-1373701175
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
URL: https://github.com/apache/spark/pull/39326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #39326:
URL: https://github.com/apache/spark/pull/39326#discussion_r1061696714
##########
core/pom.xml:
##########
@@ -181,6 +181,10 @@
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-compress</artifactId>
+ </dependency>
Review Comment:
If this isn't just a breaking change in commons-compress, then I feel like we have two different versions of common-compress in play, which could explain why just adding the dependency explicitly changed behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org