You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sunank200 (via GitHub)" <gi...@apache.org> on 2025/04/02 23:00:04 UTC
[PR] Fix deepcopy of read-only properties in BaseOperator [airflow]
sunank200 opened a new pull request, #48714:
URL: https://github.com/apache/airflow/pull/48714
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
The root cause of the [47274](https://github.com/apache/airflow/issues/47274) is that when Airflow serializes (deep-copies) an operator, the `__deepcopy__` method iterates over `self.__dict__` and sets every key using `object.__setattr__(result, k, copy.deepcopy(v, memo))`. This causes an AttributeError for read-only properties like "is_mapped" which have no setter. This PR modifies `__deepcopy__` to use `inspect.getattr_static` to detect and skip read-only properties, ensuring that `"is_mapped"` is not copied and preventing serialization errors.
I have tested this with the
<img width="1728" alt="Screenshot 2025-04-03 at 4 44 01 AM" src="https://github.com/user-attachments/assets/92aa75bb-b7e8-4848-9b98-a96c7e5de9ae" />
same DAG and setup mentioned in the issue:
<img width="1722" alt="Screenshot 2025-04-03 at 4 43 44 AM" src="https://github.com/user-attachments/assets/b7169e47-15dd-42ed-8a34-134e157ab1f3" />
closes: [47274](https://github.com/apache/airflow/issues/47274)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix deepcopy of read-only properties in BaseOperator [airflow]
Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 commented on PR #48714:
URL: https://github.com/apache/airflow/pull/48714#issuecomment-2775501317
> The other option though is to change L1260 to `result.__dict__[k] = v` -- again, since we are iterating over `self.__dict__` it must have been in there for some reason?
>
> If this doesn't fix it then lets keep that approach in our back pocket
@ashb the change you suggested in L1260 to `result.__dict__[k] = v` also works! So keeping it as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix deepcopy of read-only properties in BaseOperator [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #48714:
URL: https://github.com/apache/airflow/pull/48714#issuecomment-2773962350
i am confused because, is_mapped does not appear to be on that class 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix deepcopy of read-only properties in BaseOperator [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #48714:
URL: https://github.com/apache/airflow/pull/48714#issuecomment-2775584625
Another thing we might look at, at some point, is why we need to deepcopy in first place and whether it's possible to avoid it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix deepcopy of read-only properties in BaseOperator [airflow]
Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 commented on PR #48714:
URL: https://github.com/apache/airflow/pull/48714#issuecomment-2774656159
> i am confused because, is_mapped does not appear to be on that class 🤔
@dstandish `is_mapped` is part of AbstractOperator [here](https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/definitions/_internal/abstractoperator.py#L176) and [BaseOperator](https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/bases/operator.py#L581) uses AbstractOperator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix deepcopy of read-only properties in BaseOperator [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #48714:
URL: https://github.com/apache/airflow/pull/48714#issuecomment-2774682312
We have this section: https://github.com/apache/airflow/pull/48714/files#diff-a521dd73fbcd6da9aac5e46d98cf2e640da5467cc1b66ea7c6a87c126be35a65R1258-R1259 would it not do the trick? I also do not understand fully why its intermittent..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix deepcopy of read-only properties in BaseOperator [airflow]
Posted by "tirkarthi (via GitHub)" <gi...@apache.org>.
tirkarthi commented on PR #48714:
URL: https://github.com/apache/airflow/pull/48714#issuecomment-2776067407
It will be good to have this merged for RC1 release few hours away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix deepcopy of read-only properties in BaseOperator [airflow]
Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 commented on PR #48714:
URL: https://github.com/apache/airflow/pull/48714#issuecomment-2774811947
> https://github.com/apache/airflow/pull/48714/files#diff-a521dd73fbcd6da9aac5e46d98cf2e640da5467cc1b66ea7c6a87c126be35a65R1258-R1259
@amoghrajesh, this section doesn't help, as this tries to set the attribute for `"is_mapped"` as well as per the screenshot. and it breaks!
<img width="732" alt="Screenshot 2025-04-03 at 1 40 22 PM" src="https://github.com/user-attachments/assets/df0062ab-a344-432b-a2c5-b1dc1b6d1fdf" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix deepcopy of read-only properties in BaseOperator [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 merged PR #48714:
URL: https://github.com/apache/airflow/pull/48714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org