You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by we...@apache.org on 2019/06/21 02:58:59 UTC
[hadoop] branch branch-3.1 updated: HADOOP-14385.
HttpExceptionUtils#validateResponse swallows exceptions. Contributed by
Wei-Chiu Chuang.
This is an automated email from the ASF dual-hosted git repository.
weichiu pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new e4a6976 HADOOP-14385. HttpExceptionUtils#validateResponse swallows exceptions. Contributed by Wei-Chiu Chuang.
e4a6976 is described below
commit e4a6976c3086892c14b7968fec06214ead5d4ddb
Author: Wei-Chiu Chuang <we...@apache.org>
AuthorDate: Thu Jun 20 19:57:09 2019 -0700
HADOOP-14385. HttpExceptionUtils#validateResponse swallows exceptions. Contributed by Wei-Chiu Chuang.
Signed-off-by: Wei-Chiu Chuang <we...@apache.org>
(cherry picked from commit 840d02ca5ba013bddd28d7c1abd242b5bb8cc39f)
---
.../main/java/org/apache/hadoop/util/HttpExceptionUtils.java | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HttpExceptionUtils.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HttpExceptionUtils.java
index 50be1c3..24ed5e4 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HttpExceptionUtils.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HttpExceptionUtils.java
@@ -154,18 +154,20 @@ public class HttpExceptionUtils {
toThrow = (Exception) constr.newInstance(exMsg);
} catch (Exception ex) {
toThrow = new IOException(String.format(
- "HTTP status [%d], exception [%s], message [%s] ",
- conn.getResponseCode(), exClass, exMsg));
+ "HTTP status [%d], exception [%s], message [%s], URL [%s]",
+ conn.getResponseCode(), exClass, exMsg, conn.getURL()));
}
} else {
String msg = (exMsg != null) ? exMsg : conn.getResponseMessage();
toThrow = new IOException(String.format(
- "HTTP status [%d], message [%s]", conn.getResponseCode(), msg));
+ "HTTP status [%d], message [%s], URL [%s]",
+ conn.getResponseCode(), msg, conn.getURL()));
}
} catch (Exception ex) {
toThrow = new IOException(String.format(
- "HTTP status [%d], message [%s]", conn.getResponseCode(),
- conn.getResponseMessage()));
+ "HTTP status [%d], message [%s], URL [%s], exception [%s]",
+ conn.getResponseCode(), conn.getResponseMessage(), conn.getURL(),
+ ex.toString()), ex);
} finally {
if (es != null) {
try {
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org