You are viewing a plain text version of this content. The canonical link for it is here.

Posted to mapreduce-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/05/17 05:58:47 UTC

[jira] [Commented] (MAPREDUCE-2372) TaskLogAppender mechanism shouldn't be set in log4j.properties

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034532#comment-13034532 ] 

Tom White commented on MAPREDUCE-2372:
--------------------------------------

+1 This looks like a good change to me.

> TaskLogAppender mechanism shouldn't be set in log4j.properties
> --------------------------------------------------------------
>
>                 Key: MAPREDUCE-2372
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2372
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: task
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-2372.txt, mapreduce-2372.txt
>
>
> The TaskLogAppender log4j appender relies on using log4j.properties to pass in some Java system properties into properties of the logger. This is problematic since we've often found that users have customized log4j.properties and don't upgrade it when they upgrade the version of Hadoop.
> Since this is really an internal mechanism of how the task runner passes task info to the TLA, we shouldn't rely on these settings in log4j.properties at all. Rather, we should just get the system properties directly from System.getProperty.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira