You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/02/25 11:36:18 UTC

[GitHub] [shardingsphere] ReyYang opened a new pull request #15639: Enhance unit testing of data-pipeline

ReyYang opened a new pull request #15639:
URL: https://github.com/apache/shardingsphere/pull/15639


   Changes proposed in this pull request:
   - Fix the wrong unit test method
   - Provide new unit testing methods
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on a change in pull request #15639: Enhance unit testing of data-pipeline

Posted by GitBox <gi...@apache.org>.
sandynz commented on a change in pull request #15639:
URL: https://github.com/apache/shardingsphere/pull/15639#discussion_r814726558



##########
File path: shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/check/datasource/AbstractDataSourceCheckerTest.java
##########
@@ -64,19 +64,41 @@ public void checkVariable(final Collection<? extends DataSource> dataSources) {
             }
         };
         dataSources = new LinkedList<>();
+        RuleAlteredJobContext jobContext = new RuleAlteredJobContext(ResourceUtil.mockJobConfig());
+        dataSource = new PipelineDataSourceManager().getDataSource(jobContext.getTaskConfig().getDumperConfig().getDataSourceConfig());
         dataSources.add(dataSource);

Review comment:
       1, Could we create `dataSource` by `PipelineDataSourceCreator`, but not `RuleAlteredJobContext`.
   
   2, It's better to close `dataSource` or `PipelineDataSourceManager` after unit test.

##########
File path: shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/job/progress/JobProgressTest.java
##########
@@ -68,4 +68,16 @@ public void assertGetInventoryPosition() {
         assertTrue(jobProgress.getInventoryPosition("ds1").get("ds1.t_1") instanceof PlaceholderPosition);
         assertTrue(jobProgress.getInventoryPosition("ds1").get("ds1.t_2") instanceof PrimaryKeyPosition);
     }
+    
+    @Test
+    public void assertGetInventoryFinishedPercentage() {
+        JobProgress jobProgress = getJobProgress(ResourceUtil.readFileAndIgnoreComments("job-progress.yaml"));
+        assertThat(jobProgress.getInventoryFinishedPercentage(), is(50));
+    }
+    
+    @Test
+    public void assertGetIncrementalLatestActiveTimeMillis() {
+        JobProgress jobProgress = getJobProgress(ResourceUtil.readFileAndIgnoreComments("job-progress.yaml"));
+        assertThat(jobProgress.getIncrementalLatestActiveTimeMillis(), is(0L));
+    }

Review comment:
       Could we test more cases, e.g. there's no `incremental` data, or `latestActiveTimeMillis` has positive value.

##########
File path: shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/check/datasource/AbstractDataSourceCheckerTest.java
##########
@@ -64,19 +64,41 @@ public void checkVariable(final Collection<? extends DataSource> dataSources) {
             }
         };
         dataSources = new LinkedList<>();
+        RuleAlteredJobContext jobContext = new RuleAlteredJobContext(ResourceUtil.mockJobConfig());
+        dataSource = new PipelineDataSourceManager().getDataSource(jobContext.getTaskConfig().getDumperConfig().getDataSourceConfig());
         dataSources.add(dataSource);
     }
     
     @Test
-    public void assertCheckConnection() throws SQLException {
-        when(dataSource.getConnection()).thenReturn(connection);
+    public void assertCheckConnection() {
         dataSourceChecker.checkConnection(dataSources);
-        verify(dataSource).getConnection();
     }
     
     @Test(expected = PipelineJobPrepareFailedException.class)
     public void assertCheckConnectionFailed() throws SQLException {
-        when(dataSource.getConnection()).thenThrow(new SQLException("error"));
-        dataSourceChecker.checkConnection(dataSources);
+        DataSource mockDatasource = mock(DataSource.class);
+        when(mockDatasource.getConnection()).thenThrow(new SQLException("error"));
+        dataSourceChecker.checkConnection(Collections.singletonList(mockDatasource));
+    }
+    
+    @Test
+    public void assertCheckTargetTable() throws SQLException {
+        try (Connection connection = dataSource.getConnection();
+             Statement statement = connection.createStatement()) {
+            statement.execute("DROP TABLE IF EXISTS t_order");
+            statement.execute("CREATE TABLE t_order (order_id INT PRIMARY KEY, user_id VARCHAR(12))");
+        }
+        dataSourceChecker.checkTargetTable(dataSources, Collections.singletonList("t_order"));
+    }
+    
+    @Test(expected = PipelineJobPrepareFailedException.class)
+    public void assertCheckTargetTableFailed() throws SQLException {
+        try (Connection connection = dataSource.getConnection();
+             Statement statement = connection.createStatement()) {
+            statement.execute("DROP TABLE IF EXISTS t_order");
+            statement.execute("CREATE TABLE t_order (order_id INT PRIMARY KEY, user_id VARCHAR(12))");
+            statement.execute("INSERT INTO t_order (order_id, user_id) VALUES (1, 'xxx'), (999, 'yyy')");
+        }
+        dataSourceChecker.checkTargetTable(dataSources, Collections.singletonList("t_order"));
     }

Review comment:
       Could we test it with mocked `dataSource`, since `assertCheckConnectionFailed` already use mocked dataSource.

##########
File path: shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/job/progress/JobProgressTest.java
##########
@@ -68,4 +68,16 @@ public void assertGetInventoryPosition() {
         assertTrue(jobProgress.getInventoryPosition("ds1").get("ds1.t_1") instanceof PlaceholderPosition);
         assertTrue(jobProgress.getInventoryPosition("ds1").get("ds1.t_2") instanceof PrimaryKeyPosition);
     }
+    
+    @Test
+    public void assertGetInventoryFinishedPercentage() {
+        JobProgress jobProgress = getJobProgress(ResourceUtil.readFileAndIgnoreComments("job-progress.yaml"));
+        assertThat(jobProgress.getInventoryFinishedPercentage(), is(50));
+    }

Review comment:
       Could we test more cases, e.g. there's no finished inventory task progress.

##########
File path: shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/check/datasource/AbstractDataSourceCheckerTest.java
##########
@@ -64,19 +64,41 @@ public void checkVariable(final Collection<? extends DataSource> dataSources) {
             }
         };
         dataSources = new LinkedList<>();
+        RuleAlteredJobContext jobContext = new RuleAlteredJobContext(ResourceUtil.mockJobConfig());
+        dataSource = new PipelineDataSourceManager().getDataSource(jobContext.getTaskConfig().getDumperConfig().getDataSourceConfig());
         dataSources.add(dataSource);
     }
     
     @Test
-    public void assertCheckConnection() throws SQLException {
-        when(dataSource.getConnection()).thenReturn(connection);
+    public void assertCheckConnection() {
         dataSourceChecker.checkConnection(dataSources);
-        verify(dataSource).getConnection();
     }

Review comment:
       If `verify` removed, does it make sense?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on a change in pull request #15639: Enhance unit testing of data-pipeline

Posted by GitBox <gi...@apache.org>.
sandynz commented on a change in pull request #15639:
URL: https://github.com/apache/shardingsphere/pull/15639#discussion_r814734217



##########
File path: shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/api/impl/GovernanceRepositoryAPIImplTest.java
##########
@@ -89,7 +89,7 @@ public void assertPersistJobCheckResult() {
     public void assertDeleteJob() {

Review comment:
       `renewJobStatus` method unit test is missed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #15639: Enhance unit testing of data-pipeline

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #15639:
URL: https://github.com/apache/shardingsphere/pull/15639#issuecomment-1050985946


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#15639](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8661340) into [master](https://codecov.io/gh/apache/shardingsphere/commit/966fe8a793f1ae6ab97e2ac70aa8d6ef4c6e7a3e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (966fe8a) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 8661340 differs from pull request most recent head 262b231. Consider uploading reports for the commit 262b231 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/15639/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #15639      +/-   ##
   ============================================
   - Coverage     60.45%   60.44%   -0.02%     
   + Complexity     1987     1766     -221     
   ============================================
     Files          3232     3246      +14     
     Lines         48667    48889     +222     
     Branches       8317     8355      +38     
   ============================================
   + Hits          29420    29549     +129     
   - Misses        16832    16910      +78     
   - Partials       2415     2430      +15     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...mmand/query/simple/PostgreSQLComQueryExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L3NpbXBsZS9Qb3N0Z3JlU1FMQ29tUXVlcnlFeGVjdXRvci5qYXZh) | `58.97% <0.00%> (-23.79%)` | :arrow_down: |
   | [.../query/text/query/MySQLComQueryPacketExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvdGV4dC9xdWVyeS9NeVNRTENvbVF1ZXJ5UGFja2V0RXhlY3V0b3IuamF2YQ==) | `52.00% <0.00%> (-18.59%)` | :arrow_down: |
   | [...kend/response/header/query/QueryHeaderBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9yZXNwb25zZS9oZWFkZXIvcXVlcnkvUXVlcnlIZWFkZXJCdWlsZGVyLmphdmE=) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
   | [...nder/segment/insert/values/InsertValueContext.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9pbnNlcnQvdmFsdWVzL0luc2VydFZhbHVlQ29udGV4dC5qYXZh) | `80.00% <0.00%> (-6.37%)` | :arrow_down: |
   | [...r/jdbc/core/resultset/ShardingSphereResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvcmVzdWx0c2V0L1NoYXJkaW5nU3BoZXJlUmVzdWx0U2V0LmphdmE=) | `90.62% <0.00%> (-4.38%)` | :arrow_down: |
   | [...l/command/query/builder/ResponsePacketBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvYnVpbGRlci9SZXNwb25zZVBhY2tldEJ1aWxkZXIuamF2YQ==) | `90.90% <0.00%> (-4.33%)` | :arrow_down: |
   | [...end/postgresql/err/PostgreSQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9lcnIvUG9zdGdyZVNRTEVyclBhY2tldEZhY3RvcnkuamF2YQ==) | `48.00% <0.00%> (-4.18%)` | :arrow_down: |
   | [...ackend/text/TextProtocolBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L1RleHRQcm90b2NvbEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `61.11% <0.00%> (-2.36%)` | :arrow_down: |
   | [...roxy/frontend/mysql/err/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2Vyci9NeVNRTEVyclBhY2tldEZhY3RvcnkuamF2YQ==) | `61.11% <0.00%> (-2.36%)` | :arrow_down: |
   | [.../db/protocol/mysql/constant/MySQLCharacterSet.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMQ2hhcmFjdGVyU2V0LmphdmE=) | `98.02% <0.00%> (-1.28%)` | :arrow_down: |
   | ... and [61 more](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [966fe8a...262b231](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz merged pull request #15639: Enhance unit testing of data-pipeline

Posted by GitBox <gi...@apache.org>.
sandynz merged pull request #15639:
URL: https://github.com/apache/shardingsphere/pull/15639


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #15639: Enhance unit testing of data-pipeline

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #15639:
URL: https://github.com/apache/shardingsphere/pull/15639#issuecomment-1050985946


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#15639](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bdf444e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/966fe8a793f1ae6ab97e2ac70aa8d6ef4c6e7a3e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (966fe8a) will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/15639/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #15639      +/-   ##
   ============================================
   - Coverage     60.45%   60.43%   -0.03%     
   + Complexity     1987     1766     -221     
   ============================================
     Files          3232     3246      +14     
     Lines         48667    48906     +239     
     Branches       8317     8367      +50     
   ============================================
   + Hits          29420    29554     +134     
   - Misses        16832    16917      +85     
   - Partials       2415     2435      +20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...mmand/query/simple/PostgreSQLComQueryExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L3NpbXBsZS9Qb3N0Z3JlU1FMQ29tUXVlcnlFeGVjdXRvci5qYXZh) | `58.97% <0.00%> (-23.79%)` | :arrow_down: |
   | [.../query/text/query/MySQLComQueryPacketExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvdGV4dC9xdWVyeS9NeVNRTENvbVF1ZXJ5UGFja2V0RXhlY3V0b3IuamF2YQ==) | `52.00% <0.00%> (-18.59%)` | :arrow_down: |
   | [...kend/response/header/query/QueryHeaderBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9yZXNwb25zZS9oZWFkZXIvcXVlcnkvUXVlcnlIZWFkZXJCdWlsZGVyLmphdmE=) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
   | [...nder/segment/insert/values/InsertValueContext.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9pbnNlcnQvdmFsdWVzL0luc2VydFZhbHVlQ29udGV4dC5qYXZh) | `80.00% <0.00%> (-6.37%)` | :arrow_down: |
   | [...r/jdbc/core/resultset/ShardingSphereResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvcmVzdWx0c2V0L1NoYXJkaW5nU3BoZXJlUmVzdWx0U2V0LmphdmE=) | `90.62% <0.00%> (-4.38%)` | :arrow_down: |
   | [...l/command/query/builder/ResponsePacketBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvYnVpbGRlci9SZXNwb25zZVBhY2tldEJ1aWxkZXIuamF2YQ==) | `90.90% <0.00%> (-4.33%)` | :arrow_down: |
   | [...end/postgresql/err/PostgreSQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9lcnIvUG9zdGdyZVNRTEVyclBhY2tldEZhY3RvcnkuamF2YQ==) | `48.00% <0.00%> (-4.18%)` | :arrow_down: |
   | [...ackend/text/TextProtocolBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L1RleHRQcm90b2NvbEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `61.11% <0.00%> (-2.36%)` | :arrow_down: |
   | [...roxy/frontend/mysql/err/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2Vyci9NeVNRTEVyclBhY2tldEZhY3RvcnkuamF2YQ==) | `61.11% <0.00%> (-2.36%)` | :arrow_down: |
   | [.../db/protocol/mysql/constant/MySQLCharacterSet.java](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMQ2hhcmFjdGVyU2V0LmphdmE=) | `98.02% <0.00%> (-1.28%)` | :arrow_down: |
   | ... and [47 more](https://codecov.io/gh/apache/shardingsphere/pull/15639/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [966fe8a...bdf444e](https://codecov.io/gh/apache/shardingsphere/pull/15639?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org