You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li xu <le...@gmail.com> on 2011/08/16 19:03:48 UTC
Review Request: minor fix to enable conservcontainer sample to support any
context root
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1526/
-----------------------------------------------------------
Review request for shindig, Paul Lindner, Henry Saputra, Ryan Baxter, and Matthew Hatem.
Summary
-------
Minor updates to sample index.html so following sample works when shindig is deployed with context root other than "ROOT"
http://localhost:<port>/<context_root>/samplecontainer/examples/conservcontainer/index.html
Diffs
-----
/trunk/content/samplecontainer/examples/conservcontainer/index.html 1149643
Diff: https://reviews.apache.org/r/1526/diff
Testing
-------
passed junit tests
sample works when deployed with context root.
Thanks,
li
Re: Review Request: minor fix to enable conservcontainer sample to support
any context root
Posted by li xu <le...@gmail.com>.
> On 2011-08-16 17:21:08, Henry Saputra wrote:
> > LGTM. Could you please create JIRA case so we could track your contributions?
Thanks for reviewing it.
I have created an issue here to keep track of it : https://issues.apache.org/jira/browse/SHINDIG-1574
thanks!
- li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1526/#review1478
-----------------------------------------------------------
On 2011-08-16 17:03:48, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1526/
> -----------------------------------------------------------
>
> (Updated 2011-08-16 17:03:48)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, Ryan Baxter, and Matthew Hatem.
>
>
> Summary
> -------
>
> Minor updates to sample index.html so following sample works when shindig is deployed with context root other than "ROOT"
>
> http://localhost:<port>/<context_root>/samplecontainer/examples/conservcontainer/index.html
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1149643
>
> Diff: https://reviews.apache.org/r/1526/diff
>
>
> Testing
> -------
>
> passed junit tests
>
> sample works when deployed with context root.
>
>
> Thanks,
>
> li
>
>
Re: Review Request: minor fix to enable conservcontainer sample to support
any context root
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1526/#review1478
-----------------------------------------------------------
Ship it!
LGTM. Could you please create JIRA case so we could track your contributions?
- Henry
On 2011-08-16 17:03:48, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1526/
> -----------------------------------------------------------
>
> (Updated 2011-08-16 17:03:48)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, Ryan Baxter, and Matthew Hatem.
>
>
> Summary
> -------
>
> Minor updates to sample index.html so following sample works when shindig is deployed with context root other than "ROOT"
>
> http://localhost:<port>/<context_root>/samplecontainer/examples/conservcontainer/index.html
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1149643
>
> Diff: https://reviews.apache.org/r/1526/diff
>
>
> Testing
> -------
>
> passed junit tests
>
> sample works when deployed with context root.
>
>
> Thanks,
>
> li
>
>