You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/03/09 18:39:48 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #30001: Rename DummyStatsLogger per previous inclusivity push

eladkal commented on code in PR #30001:
URL: https://github.com/apache/airflow/pull/30001#discussion_r1131448699


##########
airflow/stats.py:
##########
@@ -182,8 +182,8 @@ def stop(self, send=True):
             self.real_timer.stop()
 
 
-class DummyStatsLogger:
-    """If no StatsLogger is configured, DummyStatsLogger is used as a fallback."""
+class NullStatsLogger:
+    """If no StatsLogger is configured, NullStatsLogger is used as a fallback."""

Review Comment:
   last time we had this naming dilemma empty won over null by great length 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org