You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/04/21 03:15:30 UTC
Review Request 58602: Friendly groups page delete function display,
and other pages of the same function in sync
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58602/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1532
https://issues.apache.org/jira/browse/RANGER-1532
Repository: ranger
Description
-------
Friendly groups page delete function display, and other pages of the same function in sync,
In ranger\security-admin\src\main\webapp\scripts\modules\globalize\message/en.js ,
" noDeleteUserRow :'Please select user first to delete.',
noDeleteGroupRow :'Please select Group first to delete.',
plsSelectUserToSetVisibility :' Please select user to set visibility or selected user is already visible/hidden.',
plsSelectGroupToSetVisibility:' Please select group to set visibility or selected group is already visible/hidden.', "
Solution :change from " noDeleteGroupRow :'Please select Group first to delete.'," to " noDeleteGroupRow :'Please select group first to delete.',".
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8f7d5d9
Diff: https://reviews.apache.org/r/58602/diff/1/
Testing
-------
tested it
Thanks,
Qiang Zhang
Re: Review Request 58602: Friendly groups page delete function
display, and other pages of the same function in sync
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58602/#review172610
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 21, 2017, 3:15 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58602/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 3:15 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1532
> https://issues.apache.org/jira/browse/RANGER-1532
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Friendly groups page delete function display, and other pages of the same function in sync,
> In ranger\security-admin\src\main\webapp\scripts\modules\globalize\message/en.js ,
> " noDeleteUserRow :'Please select user first to delete.',
> noDeleteGroupRow :'Please select Group first to delete.',
> plsSelectUserToSetVisibility :' Please select user to set visibility or selected user is already visible/hidden.',
> plsSelectGroupToSetVisibility:' Please select group to set visibility or selected group is already visible/hidden.', "
> Solution :change from " noDeleteGroupRow :'Please select Group first to delete.'," to " noDeleteGroupRow :'Please select group first to delete.',".
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 8f7d5d9
>
>
> Diff: https://reviews.apache.org/r/58602/diff/1/
>
>
> Testing
> -------
>
> tested it
>
>
> Thanks,
>
> Qiang Zhang
>
>