You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/29 16:27:53 UTC
[GitHub] [dolphinscheduler] HeZean opened a new pull request, #11695: [CI][Doc] Add lint for markdown document
HeZean opened a new pull request, #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695
## Purpose of the pull request
Resolves #8391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1247072498
> > LGTM, but I'm wondering whether there are any conflicts between `spotless flexmark step` and `lint` for markdown files? Have you experimented on it? @HeZean
>
> I prefer we use a single linter (spotless) to do the linting stuffs. It's easier for developers to verify locally and don't require another learning how superlinter works
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1230688720
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/11695?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11695](https://codecov.io/gh/apache/dolphinscheduler/pull/11695?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17e0c43) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/145e441afb36ee704b45a00df1fd33a9e782e7c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (145e441) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 17e0c43 differs from pull request most recent head 157d4e1. Consider uploading reports for the commit 157d4e1 to get more accurate results
```diff
@@ Coverage Diff @@
## dev #11695 +/- ##
============================================
- Coverage 39.81% 39.81% -0.01%
Complexity 4718 4718
============================================
Files 1002 1002
Lines 37872 37872
Branches 4230 4230
============================================
- Hits 15080 15077 -3
- Misses 21191 21194 +3
Partials 1601 1601
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/11695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...erver/master/processor/queue/TaskEventService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11695/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza0V2ZW50U2VydmljZS5qYXZh) | `75.00% <0.00%> (-5.36%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1231061651
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11695)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11695&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11695&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1231060836
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11695)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11695&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11695&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1250095675
Is this fixed by https://github.com/apache/dolphinscheduler/pull/12006?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] HeZean commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
HeZean commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1247054986
Thanks for the suggestion! I totally agree on it and will take a look at spotless, whereas I'm busy preparing for an important exam recently, please give me some time before I can step back to this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1247072899
> Thanks for the suggestion! I totally agree on it and will take a look at spotless, whereas I'm busy preparing for an important exam recently, please give me some time before I can step back to this pr.
@HeZean Good luck with the exam : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] HeZean commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
HeZean commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1235187119
@EricGao888 can we merge this PR first, and fix the lint errors in another PR? I think that may make review easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1231045141
Sorry, I closed it by mistake just now. I've reopened it. This one is great, it could save our time for reviewing and fixing docs manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] HeZean commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
HeZean commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1230551854
`VALIDATE_ALL_CODEBASE: false` -- when a contributor update a document, he/she may only wants to fix the lint errors in the file he/she modified, and I'll submit another PR to fix the existing lint errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hezean commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
hezean commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1336976935
closing this outdated pr as finished in #12977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1246972020
> LGTM, but I'm wondering whether there are any conflicts between `spotless flexmark step` and `lint` for markdown files? Have you experimented on it? @HeZean
I prefer we use a single linter (spotless) to do the linting stuffs. It's easier for developers to verify locally and don't require another learning how superlinter works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1230689629
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11695)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11695&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11695&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1230696952
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11695)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11695&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11695&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11695&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 closed pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
EricGao888 closed pull request #11695: [CI][Doc] Add lint for markdown document
URL: https://github.com/apache/dolphinscheduler/pull/11695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11695:
URL: https://github.com/apache/dolphinscheduler/pull/11695#issuecomment-1235191529
> @EricGao888 can we merge this PR first, and fix the lint errors in another PR? I think that may make review easier
I'm fine with it. WDYT? @SbloodyS BTW, @HeZean could you please add the key word `related: #xxxxxxxx` in `another PR` so that we could understand what `another PR` you are referring to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hezean closed pull request #11695: [CI][Doc] Add lint for markdown document
Posted by GitBox <gi...@apache.org>.
hezean closed pull request #11695: [CI][Doc] Add lint for markdown document
URL: https://github.com/apache/dolphinscheduler/pull/11695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org