You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/18 03:39:04 UTC
[GitHub] [superset] benjreinhart opened a new pull request #14684: chore: Perform feature/config condition checks at request time
benjreinhart opened a new pull request #14684:
URL: https://github.com/apache/superset/pull/14684
### SUMMARY
This builds on https://github.com/apache/superset/pull/14568 and https://github.com/apache/superset/pull/14650 by swapping out the remaining occurrences of code that conditionally registers resources during startup. It should now be possible to flip config/feature values on/off with restarting the server.
### TEST PLAN
I removed some disabled tests and added many more. I also tested many of these endpoints manually on my local setup.
cc @robdiciuccio @craig-rueda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37ccf99) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **decrease** coverage by `0.06%`.
> The diff coverage is `90.34%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.51% 77.45% -0.07%
==========================================
Files 958 958
Lines 48560 48634 +74
Branches 5703 5703
==========================================
+ Hits 37642 37668 +26
- Misses 10718 10766 +48
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.62% <96.03%> (+0.23%)` | :arrow_up: |
| postgres | `81.64% <96.03%> (?)` | |
| presto | `?` | |
| python | `81.72% <96.03%> (-0.14%)` | :arrow_down: |
| sqlite | `81.26% <96.03%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/SqlLab/components/SouthPane/state.ts](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9zdGF0ZS50cw==) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.62% <ø> (ø)` | |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `81.18% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `70.00% <66.66%> (ø)` | |
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| ... and [44 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [84e8dc7...37ccf99](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37ccf99) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **increase** coverage by `0.17%`.
> The diff coverage is `90.34%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
+ Coverage 77.51% 77.69% +0.17%
==========================================
Files 958 958
Lines 48560 48634 +74
Branches 5703 5703
==========================================
+ Hits 37642 37785 +143
+ Misses 10718 10649 -69
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <96.03%> (+0.23%)` | :arrow_up: |
| mysql | `81.62% <96.03%> (+0.23%)` | :arrow_up: |
| postgres | `81.64% <96.03%> (?)` | |
| presto | `81.34% <96.03%> (+0.24%)` | :arrow_up: |
| python | `82.17% <96.03%> (+0.31%)` | :arrow_up: |
| sqlite | `81.26% <96.03%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/SqlLab/components/SouthPane/state.ts](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9zdGF0ZS50cw==) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.62% <ø> (ø)` | |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `81.18% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `70.00% <66.66%> (ø)` | |
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| ... and [38 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [84e8dc7...37ccf99](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r636663886
##########
File path: superset/connectors/sqla/views.py
##########
@@ -369,6 +371,15 @@ class RowLevelSecurityFiltersModelView( # pylint: disable=too-many-ancestors
add_form_query_rel_fields = app.config["RLS_FORM_QUERY_REL_FIELDS"]
edit_form_query_rel_fields = add_form_query_rel_fields
+ @staticmethod
+ def is_enabled() -> bool:
+ return is_feature_enabled("ROW_LEVEL_SECURITY")
+
+ @before_request
+ def ensure_enabled(self) -> None:
+ if not self.is_enabled():
+ raise NotFound()
Review comment:
Gotcha - I don't have the full picture of the context in which this change is used, so some of my comments will probably be irrelevant 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fff12f4) into [master](https://codecov.io/gh/apache/superset/commit/2320bd44d4b77f6acc11d7455802bef56bf9ec52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2320bd4) will **decrease** coverage by `0.10%`.
> The diff coverage is `95.96%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.55% 77.44% -0.11%
==========================================
Files 958 958
Lines 48550 48623 +73
Branches 5703 5703
==========================================
+ Hits 37654 37658 +4
- Misses 10696 10765 +69
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.61% <95.96%> (+0.23%)` | :arrow_up: |
| postgres | `81.64% <95.96%> (+0.23%)` | :arrow_up: |
| presto | `?` | |
| python | `81.72% <95.96%> (-0.22%)` | :arrow_down: |
| sqlite | `81.26% <95.96%> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2320bd4...fff12f4](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37ccf99) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **increase** coverage by `0.09%`.
> The diff coverage is `90.34%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
+ Coverage 77.51% 77.60% +0.09%
==========================================
Files 958 958
Lines 48560 48634 +74
Branches 5703 5703
==========================================
+ Hits 37642 37744 +102
+ Misses 10718 10690 -28
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <96.03%> (+0.23%)` | :arrow_up: |
| mysql | `81.62% <96.03%> (+0.23%)` | :arrow_up: |
| postgres | `81.64% <96.03%> (?)` | |
| presto | `?` | |
| python | `82.01% <96.03%> (+0.15%)` | :arrow_up: |
| sqlite | `81.26% <96.03%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/SqlLab/components/SouthPane/state.ts](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9zdGF0ZS50cw==) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.62% <ø> (ø)` | |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `81.18% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `70.00% <66.66%> (ø)` | |
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| ... and [39 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [84e8dc7...37ccf99](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] benjreinhart commented on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
benjreinhart commented on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-845432079
@villebro Thank you for the solid feedback as always! I updated the naming and moved the order of inheritance around per the convention. If you're ok with it, I think my preference would be to hold off on a refactor around the mixin for now. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r636243376
##########
File path: superset/connectors/druid/views.py
##########
@@ -49,7 +51,18 @@
logger = logging.getLogger(__name__)
-class DruidColumnInlineView(CompactCRUDMixin, SupersetModelView):
+class EnsureEnabled:
Review comment:
nit: could this be called `EnsureEnabledMixin`?
##########
File path: superset/connectors/druid/views.py
##########
@@ -49,7 +51,18 @@
logger = logging.getLogger(__name__)
-class DruidColumnInlineView(CompactCRUDMixin, SupersetModelView):
+class EnsureEnabled:
+ @staticmethod
+ def is_enabled() -> bool:
+ return bool(app.config["DRUID_IS_ACTIVE"])
+
+ @before_request
+ def ensure_enabled(self) -> None:
+ if not self.is_enabled():
+ raise NotFound()
+
+
+class DruidColumnInlineView(CompactCRUDMixin, SupersetModelView, EnsureEnabled):
Review comment:
nit: while it really doesn't matter here, `EnsureEnabled` should probably come to the left of `SupersetModelView` as per convention (same for the others).
##########
File path: superset/connectors/sqla/views.py
##########
@@ -369,6 +371,15 @@ class RowLevelSecurityFiltersModelView( # pylint: disable=too-many-ancestors
add_form_query_rel_fields = app.config["RLS_FORM_QUERY_REL_FIELDS"]
edit_form_query_rel_fields = add_form_query_rel_fields
+ @staticmethod
+ def is_enabled() -> bool:
+ return is_feature_enabled("ROW_LEVEL_SECURITY")
+
+ @before_request
+ def ensure_enabled(self) -> None:
+ if not self.is_enabled():
+ raise NotFound()
Review comment:
We could potentially generalize this by breaking this out into a Mixin that checks `is_feature_enabled` on a reserved property. Something like this:
```python
class FeatureFlagMixin:
feature_flag: str
def is_enabled(self) -> bool:
return is_feature_enabled(self.feature_flag)
@before_request
def ensure_enabled(self) -> None:
if not self.is_enabled():
raise NotFound()
```
Then later this could be used as follows:
```python
class RowLevelSecurityFiltersModelView( # pylint: disable=too-many-ancestors
FeatureFlagMixin, SupersetModelView, DeleteMixin
):
feature_flag = "ROW_LEVEL_SECURITY"
....
```
we could potentially also add support for callbacks that make it possible to add custom validators that don't rely on `is_feature_enabled`:
```python
class FeatureFlagMixin:
feature_flag: Union[str, Callable[[], str]]
def is_enabled(self) -> bool:
if callable(self.feature_flag):
return self.feature_flag()
return is_feature_enabled(self.feature_flag)
@before_request
def ensure_enabled(self) -> None:
if not self.is_enabled():
raise NotFound()
```
and then use it like this:
```python
feature_flag = lambda _: app.config["FAB_ADD_SECURITY_VIEWS"] and app.config["SUPERSET_LOG_VIEW"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r636274548
##########
File path: superset/connectors/sqla/views.py
##########
@@ -369,6 +371,15 @@ class RowLevelSecurityFiltersModelView( # pylint: disable=too-many-ancestors
add_form_query_rel_fields = app.config["RLS_FORM_QUERY_REL_FIELDS"]
edit_form_query_rel_fields = add_form_query_rel_fields
+ @staticmethod
+ def is_enabled() -> bool:
+ return is_feature_enabled("ROW_LEVEL_SECURITY")
+
+ @before_request
+ def ensure_enabled(self) -> None:
+ if not self.is_enabled():
+ raise NotFound()
Review comment:
We could potentially generalize this by breaking this out into a Mixin that checks `is_feature_enabled` on a reserved property. Something like this:
```python
class FeatureFlagMixin:
feature_flag: str
def is_enabled(self) -> bool:
return is_feature_enabled(self.feature_flag)
@before_request
def ensure_enabled(self) -> None:
if not self.is_enabled():
raise NotFound()
```
Then later this could be used as follows:
```python
class RowLevelSecurityFiltersModelView( # pylint: disable=too-many-ancestors
FeatureFlagMixin, SupersetModelView, DeleteMixin
):
feature_flag = "ROW_LEVEL_SECURITY"
....
```
we could potentially also add support for callbacks that make it possible to add custom validators that don't rely on `is_feature_enabled`:
```python
class FeatureFlagMixin:
feature_flag: Union[str, Callable[[], bool]]
def is_enabled(self) -> bool:
if callable(self.feature_flag):
return self.feature_flag()
return is_feature_enabled(self.feature_flag)
```
and then use it like this:
```python
feature_flag = lambda _: app.config["FAB_ADD_SECURITY_VIEWS"] and app.config["SUPERSET_LOG_VIEW"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fff12f4) into [master](https://codecov.io/gh/apache/superset/commit/2320bd44d4b77f6acc11d7455802bef56bf9ec52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2320bd4) will **decrease** coverage by `0.10%`.
> The diff coverage is `95.96%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.55% 77.44% -0.11%
==========================================
Files 958 958
Lines 48550 48623 +73
Branches 5703 5703
==========================================
+ Hits 37654 37658 +4
- Misses 10696 10765 +69
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.61% <95.96%> (+0.23%)` | :arrow_up: |
| postgres | `81.64% <95.96%> (+0.23%)` | :arrow_up: |
| presto | `?` | |
| python | `81.72% <95.96%> (-0.22%)` | :arrow_down: |
| sqlite | `81.26% <95.96%> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2320bd4...fff12f4](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] benjreinhart commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
benjreinhart commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r637128566
##########
File path: superset/app.py
##########
@@ -226,10 +226,12 @@ def init_views(self) -> None:
#
# Setup regular views
#
- if appbuilder.app.config["LOGO_TARGET_PATH"]:
- appbuilder.add_link(
- "Home", label=__("Home"), href="/superset/welcome/",
- )
+ appbuilder.add_link(
+ "Home",
+ label=__("Home"),
+ href="/superset/welcome/",
+ cond=lambda: bool(appbuilder.app.config["LOGO_TARGET_PATH"]),
Review comment:
I'm not sure, but this should maintain parity with the previous code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] vedangparasnis commented on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
vedangparasnis commented on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-1076174623
What will be the json payload format required for rowlevelsecurityfiltersmodelview/api/create . I can see there is an api for rowlevelsecurityfiltersmodelview/api/, however, can this api be used to create a new row level security using api.
Thanks in advance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93e4041) into [master](https://codecov.io/gh/apache/superset/commit/9729ffd7a14e8831721da512ca6eb182bc2b0cb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9729ffd) will **decrease** coverage by `0.02%`.
> The diff coverage is `96.00%`.
> :exclamation: Current head 93e4041 differs from pull request most recent head bcdfb5c. Consider uploading reports for the commit bcdfb5c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.45% 77.43% -0.03%
==========================================
Files 959 959
Lines 48719 48793 +74
Branches 6115 6115
==========================================
+ Hits 37736 37782 +46
- Misses 10777 10805 +28
Partials 206 206
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.61% <96.00%> (+0.23%)` | :arrow_up: |
| postgres | `81.63% <96.00%> (+0.23%)` | :arrow_up: |
| python | `81.72% <96.00%> (-0.06%)` | :arrow_down: |
| sqlite | `81.25% <96.00%> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9729ffd...bcdfb5c](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93e4041) into [master](https://codecov.io/gh/apache/superset/commit/9729ffd7a14e8831721da512ca6eb182bc2b0cb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9729ffd) will **decrease** coverage by `0.02%`.
> The diff coverage is `96.00%`.
> :exclamation: Current head 93e4041 differs from pull request most recent head 3024507. Consider uploading reports for the commit 3024507 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.45% 77.43% -0.03%
==========================================
Files 959 959
Lines 48719 48793 +74
Branches 6115 6115
==========================================
+ Hits 37736 37782 +46
- Misses 10777 10805 +28
Partials 206 206
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.61% <96.00%> (+0.23%)` | :arrow_up: |
| postgres | `81.63% <96.00%> (+0.23%)` | :arrow_up: |
| python | `81.72% <96.00%> (-0.06%)` | :arrow_down: |
| sqlite | `81.25% <96.00%> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9729ffd...3024507](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] benjreinhart commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
benjreinhart commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r636424115
##########
File path: superset/connectors/sqla/views.py
##########
@@ -369,6 +371,15 @@ class RowLevelSecurityFiltersModelView( # pylint: disable=too-many-ancestors
add_form_query_rel_fields = app.config["RLS_FORM_QUERY_REL_FIELDS"]
edit_form_query_rel_fields = add_form_query_rel_fields
+ @staticmethod
+ def is_enabled() -> bool:
+ return is_feature_enabled("ROW_LEVEL_SECURITY")
+
+ @before_request
+ def ensure_enabled(self) -> None:
+ if not self.is_enabled():
+ raise NotFound()
Review comment:
I think we could, but it's a little bit more complicated then that. `@before_request` needs to be able to be scoped to a subset of route handlers in some cases. We can achieve that, but for now I think we should ship the more naive version. If this pattern continues to be used moving forward, the opportunity for a refactor should present itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio merged pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
robdiciuccio merged pull request #14684:
URL: https://github.com/apache/superset/pull/14684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fff12f4) into [master](https://codecov.io/gh/apache/superset/commit/2320bd44d4b77f6acc11d7455802bef56bf9ec52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2320bd4) will **increase** coverage by `0.04%`.
> The diff coverage is `95.96%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
+ Coverage 77.55% 77.60% +0.04%
==========================================
Files 958 958
Lines 48550 48623 +73
Branches 5703 5703
==========================================
+ Hits 37654 37734 +80
+ Misses 10696 10689 -7
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.34% <95.96%> (+0.23%)` | :arrow_up: |
| mysql | `81.61% <95.96%> (+0.23%)` | :arrow_up: |
| postgres | `81.64% <95.96%> (+0.23%)` | :arrow_up: |
| presto | `?` | |
| python | `82.01% <95.96%> (+0.07%)` | :arrow_up: |
| sqlite | `81.26% <95.96%> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2320bd4...fff12f4](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r637031354
##########
File path: superset/app.py
##########
@@ -226,10 +226,12 @@ def init_views(self) -> None:
#
# Setup regular views
#
- if appbuilder.app.config["LOGO_TARGET_PATH"]:
- appbuilder.add_link(
- "Home", label=__("Home"), href="/superset/welcome/",
- )
+ appbuilder.add_link(
+ "Home",
+ label=__("Home"),
+ href="/superset/welcome/",
+ cond=lambda: bool(appbuilder.app.config["LOGO_TARGET_PATH"]),
Review comment:
nit: `cond=lambda: appbuilder.app.config["LOGO_TARGET_PATH"] is not None`
is these a relation between "Home" menu and `LOGO_TARGET_PATH` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37ccf99) into [master](https://codecov.io/gh/apache/superset/commit/a9d888ad402ebb35da45df446997c426d6abee9d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9d888a) will **increase** coverage by `0.14%`.
> The diff coverage is `96.00%`.
> :exclamation: Current head 37ccf99 differs from pull request most recent head 93e4041. Consider uploading reports for the commit 93e4041 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
+ Coverage 77.54% 77.69% +0.14%
==========================================
Files 959 958 -1
Lines 48696 48634 -62
Branches 5743 5703 -40
==========================================
+ Hits 37762 37785 +23
+ Misses 10733 10649 -84
+ Partials 201 200 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.35% <96.00%> (+0.24%)` | :arrow_up: |
| mysql | `81.62% <96.00%> (+0.24%)` | :arrow_up: |
| postgres | `81.64% <96.00%> (+0.24%)` | :arrow_up: |
| presto | `81.34% <96.00%> (+0.25%)` | :arrow_up: |
| python | `82.17% <96.00%> (+0.24%)` | :arrow_up: |
| sqlite | `81.26% <96.00%> (+0.25%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [43 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9729ffd...93e4041](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fff12f4) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **increase** coverage by `0.08%`.
> The diff coverage is `95.96%`.
> :exclamation: Current head fff12f4 differs from pull request most recent head 37ccf99. Consider uploading reports for the commit 37ccf99 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
+ Coverage 77.51% 77.60% +0.08%
==========================================
Files 958 958
Lines 48560 48623 +63
Branches 5703 5703
==========================================
+ Hits 37642 37734 +92
+ Misses 10718 10689 -29
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.34% <95.96%> (+0.23%)` | :arrow_up: |
| mysql | `81.61% <95.96%> (+0.23%)` | :arrow_up: |
| postgres | `81.64% <95.96%> (?)` | |
| presto | `?` | |
| python | `82.01% <95.96%> (+0.15%)` | :arrow_up: |
| sqlite | `81.26% <95.96%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [84e8dc7...37ccf99](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29dff8f) into [master](https://codecov.io/gh/apache/superset/commit/9729ffd7a14e8831721da512ca6eb182bc2b0cb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9729ffd) will **decrease** coverage by `0.02%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.45% 77.43% -0.03%
==========================================
Files 959 959
Lines 48719 48797 +78
Branches 6115 6115
==========================================
+ Hits 37736 37786 +50
- Misses 10777 10805 +28
Partials 206 206
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.63% <96.00%> (+0.25%)` | :arrow_up: |
| postgres | `81.64% <96.00%> (+0.23%)` | :arrow_up: |
| python | `81.72% <96.00%> (-0.06%)` | :arrow_down: |
| sqlite | `81.27% <96.00%> (+0.25%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.31% <100.00%> (+1.88%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [25 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9729ffd...29dff8f](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fff12f4) into [master](https://codecov.io/gh/apache/superset/commit/2320bd44d4b77f6acc11d7455802bef56bf9ec52?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2320bd4) will **increase** coverage by `0.04%`.
> The diff coverage is `95.96%`.
> :exclamation: Current head fff12f4 differs from pull request most recent head c2892fd. Consider uploading reports for the commit c2892fd to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
+ Coverage 77.55% 77.60% +0.04%
==========================================
Files 958 958
Lines 48550 48623 +73
Branches 5703 5703
==========================================
+ Hits 37654 37734 +80
+ Misses 10696 10689 -7
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.34% <95.96%> (+0.23%)` | :arrow_up: |
| mysql | `81.61% <95.96%> (+0.23%)` | :arrow_up: |
| postgres | `81.64% <95.96%> (+0.23%)` | :arrow_up: |
| presto | `?` | |
| python | `82.01% <95.96%> (+0.07%)` | :arrow_up: |
| sqlite | `81.26% <95.96%> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2320bd4...c2892fd](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] benjreinhart commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
benjreinhart commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r636497130
##########
File path: tests/alerts_tests.py
##########
@@ -359,3 +364,47 @@ def test_deliver_alert_screenshot(
"|*Explore in Superset*>",
"title": f"[Alert] {alert.label}",
}
+
+
+class TestAlertsEndpoints(SupersetTestCase):
+ def test_log_model_view_disabled(self):
+ with patch.object(AlertLogModelView, "is_enabled", return_value=False):
+ self.login("admin")
+ uri = "/alertlogmodelview/list/"
+ rv = self.client.get(uri)
+ self.assertEqual(rv.status_code, 404)
+
+ def test_log_model_view_enabled(self):
+ with patch.object(AlertLogModelView, "is_enabled", return_value=True):
+ self.login("admin")
+ uri = "/alertlogmodelview/list/"
+ rv = self.client.get(uri)
+ self.assertNotEqual(rv.status_code, 404)
Review comment:
That works for me 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37ccf99) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **decrease** coverage by `0.08%`.
> The diff coverage is `90.34%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.51% 77.43% -0.09%
==========================================
Files 958 958
Lines 48560 48634 +74
Branches 5703 5703
==========================================
+ Hits 37642 37658 +16
- Misses 10718 10776 +58
Partials 200 200
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `81.64% <96.03%> (?)` | |
| presto | `?` | |
| python | `81.68% <96.03%> (-0.18%)` | :arrow_down: |
| sqlite | `81.26% <96.03%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/SqlLab/components/SouthPane/state.ts](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9zdGF0ZS50cw==) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.62% <ø> (ø)` | |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `82.26% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `81.18% <ø> (ø)` | |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `70.00% <66.66%> (ø)` | |
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| ... and [46 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [84e8dc7...37ccf99](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r636482772
##########
File path: tests/alerts_tests.py
##########
@@ -359,3 +364,47 @@ def test_deliver_alert_screenshot(
"|*Explore in Superset*>",
"title": f"[Alert] {alert.label}",
}
+
+
+class TestAlertsEndpoints(SupersetTestCase):
+ def test_log_model_view_disabled(self):
+ with patch.object(AlertLogModelView, "is_enabled", return_value=False):
+ self.login("admin")
+ uri = "/alertlogmodelview/list/"
+ rv = self.client.get(uri)
+ self.assertEqual(rv.status_code, 404)
+
+ def test_log_model_view_enabled(self):
+ with patch.object(AlertLogModelView, "is_enabled", return_value=True):
+ self.login("admin")
+ uri = "/alertlogmodelview/list/"
+ rv = self.client.get(uri)
+ self.assertNotEqual(rv.status_code, 404)
Review comment:
Nit: might be better to do a positive assertion (200) on these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] benjreinhart commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
benjreinhart commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r636493722
##########
File path: tests/alerts_tests.py
##########
@@ -359,3 +364,47 @@ def test_deliver_alert_screenshot(
"|*Explore in Superset*>",
"title": f"[Alert] {alert.label}",
}
+
+
+class TestAlertsEndpoints(SupersetTestCase):
+ def test_log_model_view_disabled(self):
+ with patch.object(AlertLogModelView, "is_enabled", return_value=False):
+ self.login("admin")
+ uri = "/alertlogmodelview/list/"
+ rv = self.client.get(uri)
+ self.assertEqual(rv.status_code, 404)
+
+ def test_log_model_view_enabled(self):
+ with patch.object(AlertLogModelView, "is_enabled", return_value=True):
+ self.login("admin")
+ uri = "/alertlogmodelview/list/"
+ rv = self.client.get(uri)
+ self.assertNotEqual(rv.status_code, 404)
Review comment:
Yes I agree, unfortunately many of these return 302s since I believe more setup is required to get the right users access to the resources. Ideally, these tests would do that, but seeing as I wasn't able to resolve it right away, I wanted to get this PR out and also keep the changes to a minimum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r636274548
##########
File path: superset/connectors/sqla/views.py
##########
@@ -369,6 +371,15 @@ class RowLevelSecurityFiltersModelView( # pylint: disable=too-many-ancestors
add_form_query_rel_fields = app.config["RLS_FORM_QUERY_REL_FIELDS"]
edit_form_query_rel_fields = add_form_query_rel_fields
+ @staticmethod
+ def is_enabled() -> bool:
+ return is_feature_enabled("ROW_LEVEL_SECURITY")
+
+ @before_request
+ def ensure_enabled(self) -> None:
+ if not self.is_enabled():
+ raise NotFound()
Review comment:
We could potentially generalize this by breaking this out into a Mixin that checks `is_feature_enabled` on a reserved property. Something like this:
```python
class FeatureFlagMixin:
feature_flag: str
def is_enabled(self) -> bool:
return is_feature_enabled(self.feature_flag)
@before_request
def ensure_enabled(self) -> None:
if not self.is_enabled():
raise NotFound()
```
Then later this could be used as follows:
```python
class RowLevelSecurityFiltersModelView( # pylint: disable=too-many-ancestors
FeatureFlagMixin, SupersetModelView, DeleteMixin
):
feature_flag = "ROW_LEVEL_SECURITY"
....
```
we could potentially also add support for callbacks that make it possible to add custom validators that don't rely on `is_feature_enabled`:
```python
class FeatureFlagMixin:
feature_flag: Union[str, Callable[[], bool]]
def is_enabled(self) -> bool:
if callable(self.feature_flag):
return self.feature_flag()
return is_feature_enabled(self.feature_flag)
@before_request
def ensure_enabled(self) -> None:
if not self.is_enabled():
raise NotFound()
```
and then use it like this:
```python
feature_flag = lambda _: app.config["FAB_ADD_SECURITY_VIEWS"] and app.config["SUPERSET_LOG_VIEW"]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29dff8f) into [master](https://codecov.io/gh/apache/superset/commit/9729ffd7a14e8831721da512ca6eb182bc2b0cb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9729ffd) will **decrease** coverage by `0.01%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.45% 77.44% -0.02%
==========================================
Files 959 959
Lines 48719 48825 +106
Branches 6115 6115
==========================================
+ Hits 37736 37813 +77
- Misses 10777 10806 +29
Partials 206 206
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.63% <96.00%> (+0.25%)` | :arrow_up: |
| postgres | `81.65% <96.00%> (+0.25%)` | :arrow_up: |
| python | `81.73% <96.00%> (-0.04%)` | :arrow_down: |
| sqlite | `81.27% <96.00%> (+0.25%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9729ffd...29dff8f](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93e4041) into [master](https://codecov.io/gh/apache/superset/commit/9729ffd7a14e8831721da512ca6eb182bc2b0cb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9729ffd) will **decrease** coverage by `0.03%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.45% 77.42% -0.04%
==========================================
Files 959 959
Lines 48719 48765 +46
Branches 6115 6115
==========================================
+ Hits 37736 37755 +19
- Misses 10777 10804 +27
Partials 206 206
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.61% <96.00%> (+0.23%)` | :arrow_up: |
| postgres | `81.62% <96.00%> (+0.22%)` | :arrow_up: |
| python | `81.70% <96.00%> (-0.08%)` | :arrow_down: |
| sqlite | `81.25% <96.00%> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.31% <100.00%> (+1.88%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9729ffd...93e4041](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14684:
URL: https://github.com/apache/superset/pull/14684#issuecomment-842808181
# [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14684](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93e4041) into [master](https://codecov.io/gh/apache/superset/commit/9729ffd7a14e8831721da512ca6eb182bc2b0cb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9729ffd) will **decrease** coverage by `0.02%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14684 +/- ##
==========================================
- Coverage 77.45% 77.43% -0.03%
==========================================
Files 959 959
Lines 48719 48793 +74
Branches 6115 6115
==========================================
+ Hits 37736 37782 +46
- Misses 10777 10805 +28
Partials 206 206
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.61% <96.00%> (+0.23%)` | :arrow_up: |
| postgres | `81.63% <96.00%> (+0.23%)` | :arrow_up: |
| python | `81.72% <96.00%> (-0.06%)` | :arrow_down: |
| sqlite | `81.25% <96.00%> (+0.23%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/access\_requests.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWNjZXNzX3JlcXVlc3RzLnB5) | `95.45% <90.00%> (-4.55%)` | :arrow_down: |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `95.00% <90.00%> (-5.00%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `64.49% <90.00%> (+4.80%)` | :arrow_up: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `83.51% <91.66%> (+3.26%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `79.87% <93.75%> (+10.07%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYXBwLnB5) | `87.68% <100.00%> (+6.08%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.01% <100.00%> (+1.57%)` | :arrow_up: |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `90.47% <100.00%> (+2.59%)` | :arrow_up: |
| [superset/views/log/api.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/tags.py](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `50.00% <100.00%> (+9.25%)` | :arrow_up: |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/14684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9729ffd...93e4041](https://codecov.io/gh/apache/superset/pull/14684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio commented on a change in pull request #14684: chore: Perform feature/config condition checks at request time
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r636496822
##########
File path: tests/alerts_tests.py
##########
@@ -359,3 +364,47 @@ def test_deliver_alert_screenshot(
"|*Explore in Superset*>",
"title": f"[Alert] {alert.label}",
}
+
+
+class TestAlertsEndpoints(SupersetTestCase):
+ def test_log_model_view_disabled(self):
+ with patch.object(AlertLogModelView, "is_enabled", return_value=False):
+ self.login("admin")
+ uri = "/alertlogmodelview/list/"
+ rv = self.client.get(uri)
+ self.assertEqual(rv.status_code, 404)
+
+ def test_log_model_view_enabled(self):
+ with patch.object(AlertLogModelView, "is_enabled", return_value=True):
+ self.login("admin")
+ uri = "/alertlogmodelview/list/"
+ rv = self.client.get(uri)
+ self.assertNotEqual(rv.status_code, 404)
Review comment:
How about `self.assertLess(rv.status_code, 400)` in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org